Remove compiler warning for internal com.sun.jndi.ldap classes by specifying them as strings instead

Author: zapodot

pom.xml

@@ -212,5 +212,23 @@
                 </plugins>
             </build>
         </profile>
+        <profile>
+            <id>java11</id>
+            <activation>
+                <jdk>11</jdk>
+            </activation>
+            <properties>
+                <java.version>11</java.version>
+            </properties>
+        </profile>
+        <profile>
+            <id>java8</id>
+            <activation>
+                <jdk>8</jdk>
+            </activation>
+            <properties>
+                <java.version>8</java.version>
+            </properties>
+        </profile>
     </profiles>
 </project>

src/main/java/org/zapodot/junit/ldap/internal/EmbeddedLdapRuleImpl.java

@@ -2,8 +2,6 @@
 
 import com.google.common.base.Charsets;
 import com.google.common.io.Resources;
-import com.sun.jndi.ldap.DefaultResponseControlFactory;
-import com.sun.jndi.ldap.LdapCtxFactory;
 import com.unboundid.ldap.listener.InMemoryDirectoryServer;
 import com.unboundid.ldap.listener.InMemoryDirectoryServerConfig;
 import com.unboundid.ldap.sdk.LDAPConnection;
@@ -29,6 +27,10 @@
 
 public class EmbeddedLdapRuleImpl implements EmbeddedLdapRule {
 
+    private static final String JAVA_RT_CONTROL_FACTORY = "com.sun.jndi.ldap.DefaultResponseControlFactory";
+
+    private static final String JAVA_RT_CONTEXT_FACTORY = "com.sun.jndi.ldap.LdapCtxFactory";
+
     private static Logger logger = LoggerFactory.getLogger(EmbeddedLdapRuleImpl.class);
     private final InMemoryDirectoryServer inMemoryDirectoryServer;
     private final AuthenticationConfiguration authenticationConfiguration;
@@ -127,11 +129,11 @@ private InitialDirContext createOrGetInitialDirContext() throws NamingException
 
     private Hashtable<String, String> createLdapEnvironment() {
         final Hashtable<String, String> environment = new Hashtable<>();
-        environment.put(LdapContext.CONTROL_FACTORIES, DefaultResponseControlFactory.class.getName());
+        environment.put(LdapContext.CONTROL_FACTORIES, JAVA_RT_CONTROL_FACTORY);
         environment.put(Context.PROVIDER_URL, String.format("ldap://%s:%s",
                                                             inMemoryDirectoryServer.getListenAddress().getHostName(),
                                                             embeddedServerPort()));
-        environment.put(Context.INITIAL_CONTEXT_FACTORY, LdapCtxFactory.class.getName());
+        environment.put(Context.INITIAL_CONTEXT_FACTORY, JAVA_RT_CONTEXT_FACTORY);
         if (authenticationConfiguration != null) {
             environment.putAll(authenticationConfiguration.toAuthenticationEnvironment());
         }