Merge pull request #282 from thc202/ignore-click-submit

kingthorin · web-flow · commit b520d2d75c05 · 2025-12-11T16:21:57.000-05:00
Ignore synthetic click event
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 ### Fixed
 - Ignore events on non-visible elements, which will fail on replay.
+- Ignore click after submit, since the former is a side effect of the latter.
 
 ## 0.1.7 - 2025-11-28
 
diff --git a/CHANGELOG.rec.md b/CHANGELOG.rec.md
@@ -7,6 +7,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 ### Fixed
 - Ignore events on non-visible elements, which will fail on replay.
+- Ignore click after submit, since the former is a side effect of the latter.
 
 ## 0.1.7 - 2025-11-28
 
diff --git a/source/ContentScript/recorder.ts b/source/ContentScript/recorder.ts
@@ -145,6 +145,15 @@ class Recorder {
     this.handleFrameSwitches(level, frame);
     console.log(event, 'ZAP clicked');
     const elementLocator = getPath(event.target as HTMLElement, element);
+
+    if ((event as MouseEvent).detail === 0) {
+      // Not a user click.
+      if (this.cachedSubmit) {
+        this.handleCachedSubmit();
+      }
+      return;
+    }
+
     this.sendZestScriptToZAP(
       new ZestStatementElementScrollTo(elementLocator, waited),
       false
diff --git a/test/ContentScript/integrationTests.test.ts b/test/ContentScript/integrationTests.test.ts
@@ -690,9 +690,29 @@ function integrationTests(
       reportZestStatementScrollTo(3, 'visibleButton'),
       reportZestStatementClick(4, 'visibleButton'),
       reportZestStatementScrollTo(5, 'visibleCheckBox'),
-      reportZestStatementClick(6, 'visibleCheckBox'),
-      reportZestStatementScrollTo(7, 'visibleCheckBox'),
-      reportZestStatementSendKeys(8, 'visibleCheckBox', 'on', 'id'),
+      reportZestStatementSendKeys(6, 'visibleCheckBox', 'on', 'id'),
+    ]);
+  });
+
+  test('Should not record click before submit', async () => {
+    // Given / When
+    await driver.toggleRecording();
+    const wd = await driver.getWebDriver();
+    await wd.get(`http://localhost:${_HTTPPORT}/webpages/submitClick.html`);
+    const input = await wd.findElement(By.id('input'));
+    await input.sendKeys('value');
+    await input.sendKeys(Key.ENTER);
+    await eventsProcessed();
+    // Then
+    expect(actualData).toEqual([
+      reportZestStatementComment(),
+      reportZestStatementLaunch(
+        'http://localhost:1801/webpages/submitClick.html'
+      ),
+      reportZestStatementScrollTo(3, 'input'),
+      reportZestStatementSendKeys(4, 'input', 'value'),
+      reportZestStatementScrollTo(5, 'input'),
+      reportZestStatementSubmit(6, 'input'),
     ]);
   });
 
diff --git a/test/ContentScript/webpages/submitClick.html b/test/ContentScript/webpages/submitClick.html
@@ -0,0 +1,12 @@
+<!DOCTYPE html>
+<html>
+  <head>
+    <title>Submit and Click</title>
+  </head>
+  <body>
+    <form>
+      <input id="input" type="text">
+      <button id="submit" type="submit">Click Me</button>
+    </form>
+  </body>
+</html>
