Clean Code

Signed-off-by: kingthorin <[email protected]>

Author: kingthorin

addOns/ascanrules/src/main/java/org/zaproxy/zap/extension/ascanrules/CrossSiteScriptingScanRule.java

@@ -294,7 +294,7 @@ private void raiseAlert(int confidence, String param, HtmlContext ctx, String ot
                 .raise();
     }
 
-    private boolean performDirectAttack(HttpMessage msg, String param, String value) {
+    private boolean performDirectAttack(HttpMessage msg, String param) {
         for (String scriptAlert : GENERIC_SCRIPT_ALERT_LIST) {
             List<HtmlContext> contexts2 =
                     performAttack(
@@ -322,8 +322,7 @@ private boolean performDirectAttack(HttpMessage msg, String param, String value)
         return false;
     }
 
-    private boolean performTagAttack(
-            HtmlContext context, HttpMessage msg, String param, String value) {
+    private boolean performTagAttack(HtmlContext context, HttpMessage msg, String param) {
 
         if (context.isInScriptAttribute()) {
             // Good chance this will be vulnerable
@@ -955,7 +954,7 @@ public void scan(HttpMessage msg, String param, String value) {
                 contexts = hca.getHtmlContexts(value + Constant.getEyeCatcher(), null, 0);
             }
             if (contexts.isEmpty()) {
-                attackWorked = performDirectAttack(msg, param, value);
+                attackWorked = performDirectAttack(msg, param);
             }
 
             for (HtmlContext context : contexts) {
@@ -966,7 +965,7 @@ public void scan(HttpMessage msg, String param, String value) {
                 }
                 if (context.getTagAttribute() != null) {
                     // its in a tag attribute - lots of attack vectors possible
-                    attackWorked = performTagAttack(context, msg, param, value);
+                    attackWorked = performTagAttack(context, msg, param);
 
                 } else if (context.isInAttributeName()) {
 

addOns/ascanrules/src/test/java/org/zaproxy/zap/extension/ascanrules/CrossSiteScriptingScanRuleUnitTest.java

@@ -2152,8 +2152,7 @@ protected Response serve(IHTTPSession session) {
                         } else {
                             response = getHtml("NoInput.html");
                         }
-                        Response resp = newFixedLengthResponse(response);
-                        return resp;
+                        return newFixedLengthResponse(response);
                     }
                 });