fix falsey settings apply

zardoy · zardoy · commit 16609aa010fd · 2025-07-08T16:35:05.000+03:00
diff --git a/src/appConfig.ts b/src/appConfig.ts
@@ -74,14 +74,15 @@ export const loadAppConfig = (appConfig: AppConfig) => {
       if (value) {
         disabledSettings.value.add(key)
         // since the setting is forced, we need to set it to that value
-        if (appConfig.defaultSettings?.[key] && !qsOptions[key]) {
+        if (appConfig.defaultSettings && key in appConfig.defaultSettings && !qsOptions[key]) {
           options[key] = appConfig.defaultSettings[key]
         }
       } else {
         disabledSettings.value.delete(key)
       }
     }
   }
+  // todo apply defaultSettings to defaults even if not forced in case of remote config
 
   if (appConfig.keybindings) {
     Object.assign(customKeymaps, defaultsDeep(appConfig.keybindings, customKeymaps))

Original file line number	Diff line number	Diff line change
`@@ -74,14 +74,15 @@ export const loadAppConfig = (appConfig: AppConfig) => {`
`74`	`74`	`if (value) {`
`75`	`75`	`disabledSettings.value.add(key)`
`76`	`76`	`// since the setting is forced, we need to set it to that value`
`77`		`- if (appConfig.defaultSettings?.[key] && !qsOptions[key]) {`
	`77`	`+ if (appConfig.defaultSettings && key in appConfig.defaultSettings && !qsOptions[key]) {`
`78`	`78`	`options[key] = appConfig.defaultSettings[key]`
`79`	`79`	`}`
`80`	`80`	`} else {`
`81`	`81`	`disabledSettings.value.delete(key)`
`82`	`82`	`}`
`83`	`83`	`}`
`84`	`84`	`}`
	`85`	`+ // todo apply defaultSettings to defaults even if not forced in case of remote config`
`85`	`86`
`86`	`87`	`if (appConfig.keybindings) {`
`87`	`88`	`Object.assign(customKeymaps, defaultsDeep(appConfig.keybindings, customKeymaps))`