Skip to content

Commit 2716279

Browse files
committed
fix volar stable release crash
1 parent 20c53f4 commit 2716279

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

typescript/src/completionEntryDetails.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,7 @@ export default function completionEntryDetails(
5757
const resolveData = {
5858
isAmbiguous: false,
5959
}
60-
console.time('resolve methodSnippet')
6160
const methodSnippet = constructMethodSnippet(languageService, sourceFile, position, symbol, c, resolveData)
62-
console.timeEnd('resolve methodSnippet')
6361
if (methodSnippet) {
6462
const data = JSON.stringify({ methodSnippet, isAmbiguous: resolveData.isAmbiguous })
6563
prior.documentation = [{ kind: 'text', text: `<!--tep ${data} e-->` }, ...(prior.documentation ?? [])]

typescript/src/completionsAtPosition.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -366,6 +366,7 @@ export const getCompletionsAtPosition = (
366366
sortText: `${entry.sortText ?? ''}${index.toString().padStart(4, '0')}`,
367367
}))
368368
}
369+
369370
const needsCompletionsSymbolMap = c('enableMethodSnippets')
370371
const completionsSymbolMap: PrevCompletionsAdditionalData['completionsSymbolMap'] = new Map()
371372
if (needsCompletionsSymbolMap) {
@@ -380,6 +381,13 @@ export const getCompletionsAtPosition = (
380381
])
381382
}
382383
}
384+
385+
// Otherwise may crash Volar
386+
prior.entries = prior.entries.map(entry => ({
387+
...entry,
388+
symbol: undefined,
389+
}))
390+
383391
return {
384392
completions: prior,
385393
prevCompletionsMap,

0 commit comments

Comments
 (0)