refactor & prepare codebase for a few next prs

kill ts server attach on ext kill

Author: zardoy

.vscode/launch.json

@@ -14,6 +14,9 @@
                 "${workspaceFolder}/out/**/*.js"
             ],
             "sourceMaps": true,
+            "cascadeTerminateToConfigurations": [
+                "Attach to TS Server",
+            ],
             "env": {
                 "TSS_DEBUG": "9223",
                 "TSS_REMOTE_DEBUG": "9223"

typescript/src/completions/sharedContext.ts

@@ -15,5 +15,6 @@ export const sharedCompletionContext = {} as unknown as Readonly<{
     formatOptions: ts.FormatCodeSettings
     preferences: ts.UserPreferences
     fullText: string
+    typeChecker: ts.TypeChecker
     // languageServiceHost: ts.LanguageServiceHost
 }>

typescript/src/completionsAtPosition.ts

@@ -141,6 +141,7 @@ export const getCompletionsAtPosition = (
         preferences: options || {},
         prior: prior!,
         fullText: sourceFile.getFullText(),
+        typeChecker: program.getTypeChecker(),
     } satisfies typeof sharedCompletionContext)
 
     if (node && !hasSuggestions && ensurePrior() && prior) {

typescript/src/references.ts

@@ -13,29 +13,29 @@ export default (proxy: ts.LanguageService, languageService: ts.LanguageService,
         }
         if (c('removeImportsFromReferences')) {
             const program = languageService.getProgram()!
-            const importsCountPerFileName: Record<
+            const refCountPerFileName: Record<
                 string,
                 {
-                    all: number
-                    cur: number
+                    total: number
+                    current: number
                 }
             > = {}
             const allReferences = prior.flatMap(({ references }) => references)
             for (const { fileName } of allReferences) {
-                importsCountPerFileName[fileName] ??= {
-                    all: 0,
-                    cur: 0,
+                refCountPerFileName[fileName] ??= {
+                    total: 0,
+                    current: 0,
                 }
-                importsCountPerFileName[fileName]!.all++
+                refCountPerFileName[fileName]!.total++
             }
             prior = prior.map(({ references, ...other }) => {
                 return {
                     ...other,
                     references: references.filter(({ fileName, textSpan }) => {
-                        const importsCount = importsCountPerFileName[fileName]!
+                        const refsCount = refCountPerFileName[fileName]!
                         // doesn't make sense to handle case where it gets imports twice
-                        if (importsCount.all <= 1 || importsCount.cur !== 0) return true
-                        importsCount.cur++
+                        if (refsCount.total <= 1 || refsCount.current !== 0) return true
+                        refsCount.current++
                         const sourceFile = program.getSourceFile(fileName)
                         if (!sourceFile) return true
                         const end = textSpan.start + textSpan.length