fix(locality-bonus): plugins completions don't display when TS returned no completions

zardoy · zardoy · commit 5c9ff75d3a85 · 2023-07-13T20:50:30.000+03:00
diff --git a/typescript/src/completionsAtPosition.ts b/typescript/src/completionsAtPosition.ts
@@ -91,8 +91,12 @@ export const getCompletionsAtPosition = (
         }
     }
     let prior = getPrior()
+    // todo rethink its usage and maybe always prefill instead
     const ensurePrior = () => {
-        if (!prior) prior = { entries: [], isGlobalCompletion: false, isMemberCompletion: false, isNewIdentifierLocation: false }
+        if (!prior) {
+            prior = { entries: [], isGlobalCompletion: false, isMemberCompletion: false, isNewIdentifierLocation: false }
+            ;(sharedCompletionContext.prior as typeof prior) = prior
+        }
         return true
     }
     const hasSuggestions = prior?.entries.some(({ kind }) => kind !== ts.ScriptElementKind.warning)

Original file line number	Diff line number	Diff line change
`@@ -91,8 +91,12 @@ export const getCompletionsAtPosition = (`
`91`	`91`	`}`
`92`	`92`	`}`
`93`	`93`	`let prior = getPrior()`
	`94`	`+ // todo rethink its usage and maybe always prefill instead`
`94`	`95`	`const ensurePrior = () => {`
`95`		`- if (!prior) prior = { entries: [], isGlobalCompletion: false, isMemberCompletion: false, isNewIdentifierLocation: false }`
	`96`	`+ if (!prior) {`
	`97`	`+ prior = { entries: [], isGlobalCompletion: false, isMemberCompletion: false, isNewIdentifierLocation: false }`
	`98`	`+ ;(sharedCompletionContext.prior as typeof prior) = prior`
	`99`	`+ }`
`96`	`100`	`return true`
`97`	`101`	`}`
`98`	`102`	`const hasSuggestions = prior?.entries.some(({ kind }) => kind !== ts.ScriptElementKind.warning)`