Skip to content

Commit 5fc1234

Browse files
committed
fix: remove useless vueSpecificImprovements setting
fixes #88
1 parent 772157d commit 5fc1234

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

src/configurationType.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,6 @@ export type Configuration = {
6363
* @default false
6464
*/
6565
enableVueSupport: boolean
66-
/**
67-
* @default true
68-
*/
69-
vueSpecificImprovements: boolean
7066
/**
7167
* Temporary setting to enable loading config from other locations (also to expose plugin)
7268
*/

typescript/src/completionsAtPosition.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,9 @@ export const getCompletionsAtPosition = (
216216
prior.entries = arrayMethods(prior.entries, position, sourceFile, c) ?? prior.entries
217217
prior.entries = jsdocDefault(prior.entries, position, sourceFile, languageService) ?? prior.entries
218218

219-
if ((fileName.endsWith('.vue.ts') || fileName.endsWith('.vue.js')) && c('vueSpecificImprovements') && exactNode) {
219+
// #region Vue (Volar) specific
220+
const isVueFile = fileName.endsWith('.vue.ts') || fileName.endsWith('.vue.js')
221+
if (isVueFile && exactNode) {
220222
let node = ts.isIdentifier(exactNode) ? exactNode.parent : exactNode
221223
if (ts.isPropertyAssignment(node)) node = node.parent
222224
if (
@@ -228,6 +230,7 @@ export const getCompletionsAtPosition = (
228230
prior.entries = prior.entries.filter(({ name, kind }) => kind === ts.ScriptElementKind.warning || !name.startsWith('__'))
229231
}
230232
}
233+
// #endregion
231234

232235
prior.entries = addSourceDefinition(prior.entries, prevCompletionsMap, c) ?? prior.entries
233236

0 commit comments

Comments
 (0)