fix: fix edge-case incorrect sorting of 10 or 100th suggestion

zardoy · zardoy · commit 7236174c5ee7 · 2022-12-14T04:20:43.000+03:00
diff --git a/typescript/src/completionsAtPosition.ts b/typescript/src/completionsAtPosition.ts
@@ -202,7 +202,8 @@ export const getCompletionsAtPosition = (
         })
     }
 
-    if (c('correctSorting.enable')) prior.entries = prior.entries.map((entry, index) => ({ ...entry, sortText: `${entry.sortText ?? ''}${index}` }))
+    if (c('correctSorting.enable'))
+        prior.entries = prior.entries.map((entry, index) => ({ ...entry, sortText: `${entry.sortText ?? ''}${index.toString().padStart(4, '0')}` }))
 
     // console.log('signatureHelp', JSON.stringify(languageService.getSignatureHelpItems(fileName, position, {})))
     return {

Original file line number	Diff line number	Diff line change
`@@ -202,7 +202,8 @@ export const getCompletionsAtPosition = (`
`202`	`202`	`})`
`203`	`203`	`}`
`204`	`204`
`205`		- if (c('correctSorting.enable')) prior.entries = prior.entries.map((entry, index) => ({ ...entry, sortText: `${entry.sortText ?? ''}${index}` }))
	`205`	`+ if (c('correctSorting.enable'))`
	`206`	+ prior.entries = prior.entries.map((entry, index) => ({ ...entry, sortText: `${entry.sortText ?? ''}${index.toString().padStart(4, '0')}` }))
`206`	`207`
`207`	`208`	`// console.log('signatureHelp', JSON.stringify(languageService.getSignatureHelpItems(fileName, position, {})))`
`208`	`209`	`return {`