fix: prevent expanding of builtin method snippets in callback destructure when indentifier

Author: zardoy

typescript/src/completions/isGoodPositionMethodCompletion.ts

@@ -13,7 +13,7 @@ export const isGoodPositionBuiltinMethodCompletion = (ts: typeof tslib, sourceFi
         if (ts.isStringLiteralLike(currentNode)) return false
         if (ts.isIdentifier(currentNode)) currentNode = currentNode.parent
         if (ts.isJsxSelfClosingElement(currentNode) || ts.isJsxOpeningElement(currentNode)) return false
-        if (ts.isShorthandPropertyAssignment(currentNode)) currentNode = currentNode.parent
+        if (ts.isBindingElement(currentNode) || ts.isShorthandPropertyAssignment(currentNode)) currentNode = currentNode.parent
         if (ts.isObjectBindingPattern(currentNode) || ts.isObjectLiteralExpression(currentNode)) return false
         if (ts.isJsxAttributes(currentNode) || ts.isJsxAttribute(currentNode)) return false
         if (c('disableMethodSnippets.jsxAttributes') && ts.isJsxExpression(currentNode)) return false

typescript/test/completions.spec.ts

@@ -101,6 +101,7 @@ test('Banned positions for all method snippets', () => {
         import {/*|*/} from 'test'
         const obj = { m$1e$2thod() {}, arrow: () => {} }
         type A = typeof obj["/*|*/"];
+        a(({ a/*|*/ }) => {})
         const test = () => ({ method() {} })
         const {/*|*/} = test()
         const {something, met/*|*/} = test()
@@ -119,7 +120,7 @@ test('Banned positions for all method snippets', () => {
         ;<Test a/*|*/ />
     `)
     for (const [i, pos] of cursorPositions.entries()) {
-        const result = isGoodPositionBuiltinMethodCompletion(ts, getSourceFile(), pos, defaultConfigFunc)
+        const result = isGoodPositionBuiltinMethodCompletion(ts, getSourceFile(), pos - 1, defaultConfigFunc)
         expect(result, i.toString()).toBeFalsy()
     }
     const insertTextEscaping = getCompletionsAtPosition(cursorPositions[1]!)!.entries[1]?.insertText!