feat: rework removeOrMarkGlobalLibCompletions text, also it was renamed from removeOrMarkGlobalCompletions!

Author: zardoy

src/configurationType.ts

@@ -45,9 +45,10 @@ export type Configuration = {
      *  */
     'removeUselessFunctionProps.enable': boolean
     /**
+     * Of course it makes no sense to use `remove`, but `mark` might be really useful
      * @default disable
      */
-    'removeOrMarkGlobalCompletions.action': 'disable' | 'mark' | 'remove'
+    'removeOrMarkGlobalLibCompletions.action': 'disable' | 'mark' | 'remove'
     /**
      * Useful for Number types.
      * Patch `toString()`: Removes arg tabstop
@@ -364,4 +365,16 @@ export type Configuration = {
      * @default false
      */
     'experiments.excludeNonJsxCompletions': boolean
+    /**
+     * Format of this setting is very close to `jsxCompletionsMap` setting:
+     * path#symbol
+     * Examples (keys in object):
+     * #join - adjust `join` symbol from every module
+     * path/win32#join - adjust `join` symbol from from path/win32 module
+     * path/
+     * Adjust actions (values in object):
+     * false - completely disable symbol(s) suggesting
+     * array of strings - change sorting of - first takes precedence for auto-imports (code actions & suggestions)
+     */
+    'autoImport.adjustBySymbol': { ['path#symbol'] }
 }

typescript/src/completions/markOrRemoveGlobalCompletions.ts renamed to typescript/src/completions/markOrRemoveGlobalLibCompletions.ts

@@ -1,27 +1,32 @@
 import { compact } from '@zardoy/utils'
 import { GetConfig } from '../types'
+import { basename } from 'path-browserify'
 
 const isLibCompletion = (symbol: ts.Symbol) => {
-    return symbol.declarations?.[0]?.getSourceFile().fileName.includes('node_modules/typescript/lib/')
+    const fileName = symbol.declarations?.[0]?.getSourceFile().fileName
+    if (!fileName) return
+    if (!fileName.includes('node_modules/typescript/lib/')) return
+    return basename(fileName).slice(0, -'.d.ts'.length)
 }
 
 export default (entries: ts.CompletionEntry[], position: number, languageService: ts.LanguageService, c: GetConfig) => {
-    const action = c('removeOrMarkGlobalCompletions.action')
+    const action = c('removeOrMarkGlobalLibCompletions.action')
     if (action === 'disable') return
 
     return compact(
         entries.map(entry => {
             if (entry.sourceDisplay) return entry
             const symbol = entry['symbol'] as ts.Symbol | undefined
             if (!symbol) return entry
-            if (!isLibCompletion(symbol)) return entry
+            const libCompletionEnding = isLibCompletion(symbol)
+            if (!libCompletionEnding) return entry
             if (action === 'remove') return undefined
             return {
                 ...entry,
                 sourceDisplay: [
                     {
                         kind: 'text',
-                        text: 'global',
+                        text: libCompletionEnding,
                     },
                 ],
             }

typescript/src/completionsAtPosition.ts

@@ -20,7 +20,7 @@ import jsdocDefault from './completions/jsdocDefault'
 import defaultHelpers from './completions/defaultHelpers'
 import objectLiteralCompletions from './completions/objectLiteralCompletions'
 import filterJsxElements from './completions/filterJsxComponents'
-import markOrRemoveGlobalCompletions from './completions/markOrRemoveGlobalCompletions'
+import markOrRemoveGlobalCompletions from './completions/markOrRemoveGlobalLibCompletions'
 import { oneOf } from '@zardoy/utils'
 
 export type PrevCompletionMap = Record<string, { originalName?: string; documentationOverride?: string | ts.SymbolDisplayPart[] }>