Skip to content

Commit 6b264c5

Browse files
ydshiehzaristei
authored andcommitted
more info in model_results.json (huggingface#39783)
more info Co-authored-by: ydshieh <[email protected]>
1 parent 1643898 commit 6b264c5

File tree

1 file changed

+17
-3
lines changed

1 file changed

+17
-3
lines changed

utils/notification_service.py

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,8 @@ def handle_test_results(test_results):
7575

7676
failed = 0
7777
success = 0
78+
errors = 0
79+
skipped = 0
7880

7981
# When the output is short enough, the output is surrounded by = signs: "== OUTPUT =="
8082
# When it is too long, those signs are not present.
@@ -83,10 +85,14 @@ def handle_test_results(test_results):
8385
for i, expression in enumerate(expressions):
8486
if "failed" in expression:
8587
failed += int(expressions[i - 1])
88+
if "errors" in expression:
89+
errors += int(expressions[i - 1])
8690
if "passed" in expression:
8791
success += int(expressions[i - 1])
92+
if "skipped" in expression:
93+
skipped += int(expressions[i - 1])
8894

89-
return failed, success, time_spent
95+
return failed, errors, success, skipped, time_spent
9096

9197

9298
def handle_stacktraces(test_results):
@@ -1188,7 +1194,9 @@ def pop_default(l: list[Any], i: int, default: Any) -> Any:
11881194
matrix_job_results = {
11891195
matrix_name: {
11901196
"failed": {m: {"unclassified": 0, "single": 0, "multi": 0} for m in test_categories},
1197+
"errors": 0,
11911198
"success": 0,
1199+
"skipped": 0,
11921200
"time_spent": "",
11931201
"failures": {},
11941202
"job_link": {},
@@ -1213,8 +1221,10 @@ def pop_default(l: list[Any], i: int, default: Any) -> Any:
12131221
# Link to the GitHub Action job
12141222
job = artifact_name_to_job_map[path]
12151223
matrix_job_results[matrix_name]["job_link"][artifact_gpu] = job["html_url"]
1216-
failed, success, time_spent = handle_test_results(artifact["stats"])
1224+
failed, errors, success, skipped, time_spent = handle_test_results(artifact["stats"])
12171225
matrix_job_results[matrix_name]["success"] += success
1226+
matrix_job_results[matrix_name]["errors"] += errors
1227+
matrix_job_results[matrix_name]["skipped"] += skipped
12181228
matrix_job_results[matrix_name]["time_spent"] += time_spent[1:-1] + ", "
12191229

12201230
stacktraces = handle_stacktraces(artifact["failures_line"])
@@ -1317,7 +1327,9 @@ def pop_default(l: list[Any], i: int, default: Any) -> Any:
13171327
additional_results = {
13181328
key: {
13191329
"failed": {"unclassified": 0, "single": 0, "multi": 0},
1330+
"errors": 0,
13201331
"success": 0,
1332+
"skipped": 0,
13211333
"time_spent": "",
13221334
"error": False,
13231335
"failures": {},
@@ -1343,9 +1355,11 @@ def pop_default(l: list[Any], i: int, default: Any) -> Any:
13431355
artifact = retrieve_artifact(path, artifact_gpu)
13441356
stacktraces = handle_stacktraces(artifact["failures_line"])
13451357

1346-
failed, success, time_spent = handle_test_results(artifact["stats"])
1358+
failed, errors, success, skipped, time_spent = handle_test_results(artifact["stats"])
13471359
additional_results[key]["failed"][artifact_gpu or "unclassified"] += failed
13481360
additional_results[key]["success"] += success
1361+
additional_results[key]["errors"] += errors
1362+
additional_results[key]["skipped"] += skipped
13491363
additional_results[key]["time_spent"] += time_spent[1:-1] + ", "
13501364

13511365
if len(artifact["errors"]):

0 commit comments

Comments
 (0)