File tree Expand file tree Collapse file tree 1 file changed +5
-3
lines changed
Expand file tree Collapse file tree 1 file changed +5
-3
lines changed Original file line number Diff line number Diff line change @@ -133,8 +133,8 @@ def convert_v3_to_v2_metadata(
133133 The metadata object in v2 format.
134134 """
135135
136- # TODO: Find a more robust way to exclude any bytes codecs
137- # TODO: Test round-tripping big endian since that is stored in the bytes codec in V3; it should be included in data type instead for V2
136+ # TODO: Check that all ArrayBytesCodecs should in fact be excluded for V2 metadata storage.
137+ # TODO: Test round-tripping big endian since that is stored in the bytes codec in V3; it should be included in data type instead for V2.
138138 v2_codecs = [
139139 zarr_codec_config_to_v2 (get_codec_config (codec ))
140140 for codec in v3_metadata .codecs
@@ -145,7 +145,9 @@ def convert_v3_to_v2_metadata(
145145 dtype = v3_metadata .data_type ,
146146 chunks = v3_metadata .chunks ,
147147 fill_value = fill_value or v3_metadata .fill_value ,
148- filters = v2_codecs ,
148+ filters = v2_codecs
149+ if v2_codecs
150+ else None , # Do not pass an empty list to ArrayV2Metadata
149151 compressor = None ,
150152 order = "C" ,
151153 attributes = v3_metadata .attributes ,
You can’t perform that action at this time.
0 commit comments