Remove _FillValue from attributes in dmrpp _parse_variable

Author: abarciauskas-bgse

virtualizarr/readers/dmrpp.py

@@ -411,8 +411,9 @@ def _parse_variable(self, var_tag: ET.Element) -> Variable:
         attrs: dict[str, Any] = {}
         for attr_tag in var_tag.iterfind("dap:Attribute", self._NS):
             attrs.update(self._parse_attribute(attr_tag))
-        # Fill value is placed in encoding and thus removed from attributes
-        fill_value = attrs.get("_FillValue", None)
+        # Fill value is placed in zarr array's fill_value and variable encoding and removed from attributes
+        encoding = {k: attrs.get(k) for k in self._ENCODING_KEYS if k in attrs}
+        fill_value = attrs.pop("_FillValue", None)
         # create ManifestArray and ZArray
         zarray = ZArray(
             chunks=chunks_shape,
@@ -423,7 +424,6 @@ def _parse_variable(self, var_tag: ET.Element) -> Variable:
             shape=shape,
         )
         marr = ManifestArray(zarray=zarray, chunkmanifest=chunkmanifest)
-        encoding = {k: attrs.get(k) for k in self._ENCODING_KEYS if k in attrs}
         return Variable(dims=dims.keys(), data=marr, attrs=attrs, encoding=encoding)
 
     def _parse_attribute(self, attr_tag: ET.Element) -> dict[str, Any]:

virtualizarr/tests/test_readers/test_dmrpp.py

@@ -307,7 +307,6 @@ def test_parse_variable(tmp_path):
         "coordinates": "x y z",
         "add_offset": 298.15,
         "scale_factor": 0.001,
-        "_FillValue": -32768,
     }