Skip to content

Commit 153d340

Browse files
committed
pr feedback
1 parent f39b32d commit 153d340

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/workflows/ci.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ jobs:
7979
8080
# This is used to test with zfpy, which does not yet support numpy 2.0
8181
- name: Install older numpy and zfpy
82-
if: matrix.python-version == '3.11' && matrix.platform != 'macos-14'
82+
if: matrix.python-version == '3.11'
8383
shell: "bash -l {0}"
8484
run: |
8585
conda activate env

numcodecs/zarr3.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def _expect_name_prefix(codec_name: str) -> str:
5858
raise ValueError(
5959
f"Expected name to start with '{CODEC_PREFIX}'. Got {codec_name} instead."
6060
) # pragma: no cover
61-
return codec_name[len(CODEC_PREFIX) :]
61+
return codec_name.removeprefix(CODEC_PREFIX)
6262

6363

6464
def _parse_codec_configuration(data: dict[str, JSON]) -> dict[str, JSON]:
@@ -114,7 +114,7 @@ def to_dict(self) -> JSON:
114114
}
115115

116116
def compute_encoded_size(self, input_byte_length: int, chunk_spec: ArraySpec) -> int:
117-
return input_byte_length # pragma: no cover
117+
raise NotImplementedError # pragma: no cover
118118

119119

120120
class _NumcodecsBytesBytesCodec(_NumcodecsCodec, BytesBytesCodec):

0 commit comments

Comments
 (0)