Skip to content

Commit 85eeed3

Browse files
authored
Unskip accidentally skipped tests (#738)
1 parent 58bc9c4 commit 85eeed3

File tree

2 files changed

+15
-15
lines changed

2 files changed

+15
-15
lines changed

numcodecs/tests/common.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ def check_backwards_compatibility(codec_id, arrays, codecs, precision=None, pref
202202

203203
for j, codec in enumerate(codecs):
204204
if codec is None:
205-
pytest.skip("codec has been removed")
205+
continue
206206

207207
# setup a directory to hold encoded data
208208
codec_dir = os.path.join(fixture_dir, f'codec.{j:02d}')

numcodecs/tests/test_blosc.py

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -245,20 +245,20 @@ def test_err_encode_object_buffer():
245245
check_err_encode_object_buffer(Blosc())
246246

247247

248-
def test_decompression_error_handling():
249-
for codec in codecs:
250-
_skip_null(codec)
251-
with pytest.raises(RuntimeError):
252-
codec.decode(bytearray())
253-
with pytest.raises(RuntimeError):
254-
codec.decode(bytearray(0))
255-
256-
257-
def test_max_buffer_size():
258-
for codec in codecs:
259-
_skip_null(codec)
260-
assert codec.max_buffer_size == 2**31 - 1
261-
check_max_buffer_size(codec)
248+
@pytest.mark.parametrize('codec', codecs)
249+
def test_decompression_error_handling(codec):
250+
_skip_null(codec)
251+
with pytest.raises(RuntimeError):
252+
codec.decode(bytearray())
253+
with pytest.raises(RuntimeError):
254+
codec.decode(bytearray(0))
255+
256+
257+
@pytest.mark.parametrize('codec', codecs)
258+
def test_max_buffer_size(codec):
259+
_skip_null(codec)
260+
assert codec.max_buffer_size == 2**31 - 1
261+
check_max_buffer_size(codec)
262262

263263

264264
def test_typesize_explicit():

0 commit comments

Comments
 (0)