Last batch of ruff rules (#658)

* Enforce ruff rule RUF001

Disable the rule directly in the incriminated test file.

* Enforce ruff/pyupgrade rule UP007

UP007 Use `X | Y` for type annotations

* Enforce ruff/flake8-bugbear rules B028 and B904

* Exclude c-blosc from ruff linting

* Ignore ruff/pycodestyle rule W391

astral-sh/ruff#13763

* Enforce ruff/flake8-logging rules (LOG)

* Enforce ruff/flake8-implicit-str-concat rules (ISC)

* Enforce ruff/flake8-executable rules (EXE)

* Enforce ruff/flake8-future-annotations rules (FA)

* Enforce ruff/flake8-return rules (RET)

* Enforce ruff/flake8-slots rules (SLOT)

* Add "numcodecs" to "src"

The directories to consider when resolving first- vs. third-party imports.

* Enforce ruff/flake8-simplify rules (SIM)

* Enforce ruff/flake8-tidy-imports rules (TID)

* Conflicting ruff lint rules

The linter includes some rules that, when enabled, can cause conflicts
with the formatter, leading to unexpected behavior. None None of these
rules are included in Ruff's default configuration. However, since we
have enabled some relevant rule sets, we disable these rules.

* Enforce ruff/tryceratops rules (TRY)

* Update ruff to 0.8.0

* Ignore ruff/flake8-simplify rule SIM105

SIM105 Use `contextlib.suppress(ImportError)` instead of `try`-`except`-`pass`

* Ignore ruff/tryceratops rule TRY301

TRY301 Abstract `raise` to an inner function

* Apply ruff/flake8-bugbear rule B904

B904 Within an `except` clause, raise exceptions with `raise ... from err`
     or `raise ... from None` to distinguish them from errors in exception
     handling

* Apply ruff/flake8-bugbear rule B028

B028 No explicit `stacklevel` keyword argument found

* Apply ruff rule RUF022

RUF022 `__all__` is not sorted

Author: DimitriPapadopoulos

adhoc/blosc_memleak_check.py

@@ -1,10 +1,9 @@
 import sys
 
+import numcodecs
 import numpy as np
 from numpy.testing import assert_array_equal
 
-import numcodecs
-
 codec = numcodecs.Blosc()
 data = np.arange(int(sys.argv[1]))
 for _ in range(int(sys.argv[2])):

notebooks/benchmark_vlen.ipynb

@@ -24,9 +24,8 @@
     }
    ],
    "source": [
-    "import numpy as np\n",
-    "\n",
     "import numcodecs\n",
+    "import numpy as np\n",
     "\n",
     "numcodecs.__version__"
    ]

numcodecs/astype.py

@@ -49,9 +49,7 @@ def encode(self, buf):
         arr = ensure_ndarray(buf).view(self.decode_dtype)
 
         # convert and copy
-        enc = arr.astype(self.encode_dtype)
-
-        return enc
+        return arr.astype(self.encode_dtype)
 
     def decode(self, buf, out=None):
         # normalise input
@@ -61,9 +59,7 @@ def decode(self, buf, out=None):
         dec = enc.astype(self.decode_dtype)
 
         # handle output
-        out = ndarray_copy(dec, out)
-
-        return out
+        return ndarray_copy(dec, out)
 
     def get_config(self):
         return {

numcodecs/base64.py

@@ -13,8 +13,7 @@ def encode(self, buf):
         # normalise inputs
         buf = ensure_contiguous_ndarray(buf)
         # do compression
-        compressed = _base64.standard_b64encode(buf)
-        return compressed
+        return _base64.standard_b64encode(buf)
 
     def decode(self, buf, out=None):
         # normalise inputs

numcodecs/categorize.py

@@ -80,18 +80,15 @@ def decode(self, buf, out=None):
             dec[enc == (i + 1)] = label
 
         # handle output
-        dec = ndarray_copy(dec, out)
-
-        return dec
+        return ndarray_copy(dec, out)
 
     def get_config(self):
-        config = {
+        return {
             'id': self.codec_id,
             'labels': self.labels,
             'dtype': self.dtype.str,
             'astype': self.astype.str,
         }
-        return config
 
     def __repr__(self):
         # make sure labels part is not too long

numcodecs/delta.py

@@ -85,9 +85,7 @@ def decode(self, buf, out=None):
         np.cumsum(enc, out=dec)
 
         # handle output
-        out = ndarray_copy(dec, out)
-
-        return out
+        return ndarray_copy(dec, out)
 
     def get_config(self):
         # override to handle encoding dtypes

numcodecs/fixedscaleoffset.py

@@ -94,9 +94,7 @@ def encode(self, buf):
         enc = np.around(enc)
 
         # convert dtype
-        enc = enc.astype(self.astype, copy=False)
-
-        return enc
+        return enc.astype(self.astype, copy=False)
 
     def decode(self, buf, out=None):
         # interpret buffer as numpy array

numcodecs/gzip.py

@@ -28,9 +28,7 @@ def encode(self, buf):
         compressed = io.BytesIO()
         with _gzip.GzipFile(fileobj=compressed, mode='wb', compresslevel=self.level) as compressor:
             compressor.write(buf)
-        compressed = compressed.getvalue()
-
-        return compressed
+        return compressed.getvalue()
 
     # noinspection PyMethodMayBeStatic
     def decode(self, buf, out=None):

numcodecs/lzma.py

@@ -5,7 +5,7 @@
 try:
     import lzma as _lzma
 except ImportError:  # pragma: no cover
-    try:
+    try:  # noqa: SIM105
         from backports import lzma as _lzma  # type: ignore[no-redef]
     except ImportError:
         pass

numcodecs/ndarray_like.py

@@ -1,4 +1,4 @@
-from typing import Any, ClassVar, Optional, Protocol, runtime_checkable
+from typing import Any, ClassVar, Protocol, runtime_checkable
 
 
 class _CachedProtocolMeta(Protocol.__class__):  # type: ignore[name-defined]
@@ -53,7 +53,7 @@ def __getitem__(self, key) -> Any: ...  # pragma: no cover
 
     def __setitem__(self, key, value): ...  # pragma: no cover
 
-    def tobytes(self, order: Optional[str] = ...) -> bytes: ...  # pragma: no cover
+    def tobytes(self, order: str | None = ...) -> bytes: ...  # pragma: no cover
 
     def reshape(self, *shape: int, order: str = ...) -> "NDArrayLike": ...  # pragma: no cover