Apply and enforce ruff/flake8-bugbear rules (B)

B007 Loop control variable not used within loop body

B028 No explicit `stacklevel` keyword argument found

B904 Within an `except` clause, raise exceptions with `raise ... from err` or
     `raise ... from None` to distinguish them from errors in exception handling

B905 `zip()` without an explicit `strict=` parameter

Author: DimitriPapadopoulos

adhoc/blosc_memleak_check.py

@@ -7,7 +7,7 @@
 
 codec = numcodecs.Blosc()
 data = np.arange(int(sys.argv[1]))
-for i in range(int(sys.argv[2])):
+for _i in range(int(sys.argv[2])):
     enc = codec.encode(data)
     dec = codec.decode(enc)
     arr = np.frombuffer(dec, dtype=data.dtype)

numcodecs/tests/common.py

@@ -200,7 +200,7 @@ def assert_array_items_equal(res, arr):
     # and values
     arr = arr.ravel().tolist()
     res = res.ravel().tolist()
-    for a, r in zip(arr, res):
+    for a, r in zip(arr, res, strict=True):
         if isinstance(a, np.ndarray):
             assert_array_equal(a, r)
         elif a != a:

numcodecs/tests/test_lzma.py

@@ -9,8 +9,8 @@
 try:
     # noinspection PyProtectedMember
     from numcodecs.lzma import LZMA, _lzma
-except ImportError:  # pragma: no cover
-    raise unittest.SkipTest("LZMA not available")
+except ImportError as e:  # pragma: no cover
+    raise unittest.SkipTest("LZMA not available") from e
 
 
 from numcodecs.tests.common import (

numcodecs/tests/test_msgpacks.py

@@ -7,8 +7,8 @@
 
 try:
     from numcodecs.msgpacks import MsgPack
-except ImportError:  # pragma: no cover
-    raise unittest.SkipTest("msgpack not available")
+except ImportError as e:  # pragma: no cover
+    raise unittest.SkipTest("msgpack not available") from e
 
 
 from numcodecs.tests.common import (

numcodecs/tests/test_registry.py

@@ -27,8 +27,8 @@ def test_all_classes_registered():
     see #346 for more info
     """
     missing = set()
-    for name, submod in inspect.getmembers(numcodecs, inspect.ismodule):
-        for name, obj in inspect.getmembers(submod):
+    for _name, submod in inspect.getmembers(numcodecs, inspect.ismodule):
+        for _name, obj in inspect.getmembers(submod):
             if inspect.isclass(obj):
                 if issubclass(obj, numcodecs.abc.Codec):
                     if obj.codec_id not in numcodecs.registry.codec_registry:

numcodecs/tests/test_vlen_array.py

@@ -5,8 +5,8 @@
 
 try:
     from numcodecs.vlen import VLenArray
-except ImportError:  # pragma: no cover
-    raise unittest.SkipTest("vlen-array not available")
+except ImportError as e:  # pragma: no cover
+    raise unittest.SkipTest("vlen-array not available") from e
 from numcodecs.tests.common import (
     check_config,
     check_repr,

numcodecs/tests/test_vlen_bytes.py

@@ -5,8 +5,8 @@
 
 try:
     from numcodecs.vlen import VLenBytes
-except ImportError:  # pragma: no cover
-    raise unittest.SkipTest("vlen-bytes not available")
+except ImportError as e:  # pragma: no cover
+    raise unittest.SkipTest("vlen-bytes not available") from e
 from numcodecs.tests.common import (
     check_config,
     check_repr,

numcodecs/tests/test_vlen_utf8.py

@@ -7,8 +7,8 @@
 
 try:
     from numcodecs.vlen import VLenUTF8
-except ImportError:  # pragma: no cover
-    raise unittest.SkipTest("vlen-utf8 not available")
+except ImportError as e:  # pragma: no cover
+    raise unittest.SkipTest("vlen-utf8 not available") from e
 from numcodecs.tests.common import (
     check_config,
     check_repr,

numcodecs/zfpy.py

@@ -17,6 +17,7 @@
             "NumPy version >= 2.0.0 detected. The zfpy library is incompatible with this version of NumPy. "
             "Please downgrade to NumPy < 2.0.0 or wait for an update from zfpy.",
             UserWarning,
+            stacklevel=2,
         )
     else:
         with suppress(ImportError):

pyproject.toml

@@ -134,7 +134,7 @@ environment = { DISABLE_NUMCODECS_AVX2=1, DISABLE_NUMCODECS_SSE2=1 }
 line-length = 100
 
 [tool.ruff.lint]
-extend-select = [ "RUF" ]
+extend-select = [ "B", "RUF" ]
 ignore = [ "RUF001" ]
 
 [tool.ruff.format]