don't check if the abc is registered in test_all_classes_registered

d-v-b · d-v-b · commit d64b1c15aea0 · 2025-02-12T10:42:51.000+01:00
diff --git a/numcodecs/tests/test_registry.py b/numcodecs/tests/test_registry.py
@@ -34,6 +34,7 @@ def test_all_classes_registered():
         if (
             inspect.isclass(obj)
             and issubclass(obj, numcodecs.abc.Codec)
+            and hasattr(obj, 'codec_id')
             and obj.codec_id not in numcodecs.registry.codec_registry
             and obj.codec_id is not None  # remove `None`
         )

Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,7 @@ def test_all_classes_registered():`
`34`	`34`	`if (`
`35`	`35`	`inspect.isclass(obj)`
`36`	`36`	`and issubclass(obj, numcodecs.abc.Codec)`
	`37`	`+ and hasattr(obj, 'codec_id')`
`37`	`38`	`and obj.codec_id not in numcodecs.registry.codec_registry`
`38`	`39`	and obj.codec_id is not None # remove `None`
`39`	`40`	`)`