From 1616b3b23b14fcc67a12f2ff6e6ed3d885a05103 Mon Sep 17 00:00:00 2001 From: David Stansby Date: Sat, 9 Nov 2024 10:44:02 +0000 Subject: [PATCH 1/3] Fix minimum numpy pin --- pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index 8e1a03f8..5a1701f1 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -15,7 +15,7 @@ A Python package providing buffer compression and transformation codecs \ for use in data storage and communication applications.""" readme = "README.rst" dependencies = [ - "numpy>=1.23", + "numpy>=1.24", ] requires-python = ">=3.11" dynamic = [ From 63fdd913b01edb9193b9313562a4dd4074df48a5 Mon Sep 17 00:00:00 2001 From: David Stansby Date: Sat, 9 Nov 2024 10:45:47 +0000 Subject: [PATCH 2/3] Make sure we test minimum version of numpy --- .github/workflows/ci.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 8789102d..6ec79e50 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -72,6 +72,9 @@ jobs: - name: Install zarr-python shell: "bash -l {0}" + # Since zarr v3 requires numpy >= 1.25, on Python 3.11 leave it out + # so we can have some tests of our minimum version of numpy (1.24) + if: matrix.python-version != '3.11' run: | conda activate env # TODO: remove --pre option when zarr v3 is out From 51fcbbea2c82bdd96a269b2bb3c4abc4e40f3c59 Mon Sep 17 00:00:00 2001 From: Norman Rzepka Date: Sat, 9 Nov 2024 12:05:04 +0100 Subject: [PATCH 3/3] swap import order --- numcodecs/tests/test_zarr3.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/numcodecs/tests/test_zarr3.py b/numcodecs/tests/test_zarr3.py index 78d824e2..ec1a398e 100644 --- a/numcodecs/tests/test_zarr3.py +++ b/numcodecs/tests/test_zarr3.py @@ -3,10 +3,10 @@ import numpy as np import pytest -import numcodecs.zarr3 - zarr = pytest.importorskip("zarr") +import numcodecs.zarr3 # noqa: E402 + pytestmark = [ pytest.mark.skipif(zarr.__version__ < "3.0.0", reason="zarr 3.0.0 or later is required"), pytest.mark.filterwarnings("ignore:Codec 'numcodecs.*' not configured in config.*:UserWarning"),