Skip to content

Conversation

@DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Dec 11, 2024

  • Python 3 is the default nowadays, no need to specify it.
  • Update pre-commmit less often than the "weekly" default.

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

* Python 3 is the default nowadays, no need to specify it.
* Update pre-commmit less often that the "weekly" default.
@codecov
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.92%. Comparing base (bfa1c0d) to head (4239942).
Report is 26 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #668   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          62       62           
  Lines        2761     2761           
=======================================
  Hits         2759     2759           
  Misses          2        2           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dstansby dstansby merged commit 095de5c into zarr-developers:main Dec 28, 2024
26 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the pre-commit branch December 29, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants