From 5fdc3586cff9d982f657e0cc18c03343c4e45696 Mon Sep 17 00:00:00 2001 From: David Stansby Date: Thu, 10 Apr 2025 18:58:11 +0200 Subject: [PATCH] Unskip accidentally skipped tests --- numcodecs/tests/common.py | 2 +- numcodecs/tests/test_blosc.py | 28 ++++++++++++++-------------- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/numcodecs/tests/common.py b/numcodecs/tests/common.py index 12cccb20..75534fe8 100644 --- a/numcodecs/tests/common.py +++ b/numcodecs/tests/common.py @@ -202,7 +202,7 @@ def check_backwards_compatibility(codec_id, arrays, codecs, precision=None, pref for j, codec in enumerate(codecs): if codec is None: - pytest.skip("codec has been removed") + continue # setup a directory to hold encoded data codec_dir = os.path.join(fixture_dir, f'codec.{j:02d}') diff --git a/numcodecs/tests/test_blosc.py b/numcodecs/tests/test_blosc.py index e5a40df6..81725018 100644 --- a/numcodecs/tests/test_blosc.py +++ b/numcodecs/tests/test_blosc.py @@ -245,20 +245,20 @@ def test_err_encode_object_buffer(): check_err_encode_object_buffer(Blosc()) -def test_decompression_error_handling(): - for codec in codecs: - _skip_null(codec) - with pytest.raises(RuntimeError): - codec.decode(bytearray()) - with pytest.raises(RuntimeError): - codec.decode(bytearray(0)) - - -def test_max_buffer_size(): - for codec in codecs: - _skip_null(codec) - assert codec.max_buffer_size == 2**31 - 1 - check_max_buffer_size(codec) +@pytest.mark.parametrize('codec', codecs) +def test_decompression_error_handling(codec): + _skip_null(codec) + with pytest.raises(RuntimeError): + codec.decode(bytearray()) + with pytest.raises(RuntimeError): + codec.decode(bytearray(0)) + + +@pytest.mark.parametrize('codec', codecs) +def test_max_buffer_size(codec): + _skip_null(codec) + assert codec.max_buffer_size == 2**31 - 1 + check_max_buffer_size(codec) def test_typesize_explicit():