Skip to content

Commit 02f3a27

Browse files
committed
adopt allocateFillValueChunk() and chunkKeyEncoding()
1 parent e287318 commit 02f3a27

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

src/main/java/dev/zarr/zarrjava/v2/ArrayMetadata.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,11 @@
44
import com.fasterxml.jackson.annotation.JsonIgnore;
55
import com.fasterxml.jackson.annotation.JsonProperty;
66
import dev.zarr.zarrjava.ZarrException;
7+
import dev.zarr.zarrjava.utils.MultiArrayUtils;
78
import dev.zarr.zarrjava.v3.DataType;
89
import dev.zarr.zarrjava.v3.chunkkeyencoding.ChunkKeyEncoding;
910
import dev.zarr.zarrjava.v3.chunkkeyencoding.Separator;
11+
import dev.zarr.zarrjava.v3.chunkkeyencoding.V2ChunkKeyEncoding;
1012
import dev.zarr.zarrjava.v3.codec.Codec;
1113
import ucar.ma2.Array;
1214

@@ -108,14 +110,15 @@ public DataType dataType() {
108110

109111
@Override
110112
public Array allocateFillValueChunk() {
111-
//TODO
112-
return null;
113+
ucar.ma2.Array outputArray = ucar.ma2.Array.factory(dataType.getMA2DataType(), chunks);
114+
MultiArrayUtils.fill(outputArray, parsedFillValue);
115+
return outputArray;
113116
}
114117

115118
@Override
116119
public ChunkKeyEncoding chunkKeyEncoding() {
117-
//TODO
118-
return null;
120+
Separator separator = dimensionSeparator == null ? Separator.DOT : dimensionSeparator;
121+
return new V2ChunkKeyEncoding(new V2ChunkKeyEncoding.Configuration(separator));
119122
}
120123

121124
@Override

src/test/java/dev/zarr/zarrjava/ZarrTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -697,7 +697,6 @@ public void testMetadataAcceptsEmptyStorageTransformer() throws ZarrException, I
697697
));
698698
}
699699

700-
// TODO test withBloscCompressor
701700
@ParameterizedTest
702701
@CsvSource({"blosclz,noshuffle,0", "lz4,shuffle,6", "lz4hc,bitshuffle,3", "zlib,shuffle,5", "zstd,bitshuffle,9"})
703702
public void testV2create(String cname, String shuffle, int clevel) throws IOException, ZarrException {

0 commit comments

Comments
 (0)