test and fix v3 Group Attributes

Author: brokkoli71

src/main/java/dev/zarr/zarrjava/v3/Group.java

@@ -55,7 +55,7 @@ public static Group create(
       @Nonnull StoreHandle storeHandle,
       @Nonnull Attributes attributes
   ) throws IOException, ZarrException {
-    return new Group(storeHandle, new GroupMetadata(attributes));
+    return create(storeHandle, new GroupMetadata(attributes));
   }
 
   public static Group create(@Nonnull StoreHandle storeHandle) throws IOException, ZarrException {

src/main/java/dev/zarr/zarrjava/v3/GroupMetadata.java

@@ -1,13 +1,15 @@
 package dev.zarr.zarrjava.v3;
 
 import com.fasterxml.jackson.annotation.JsonCreator;
+import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
 import com.fasterxml.jackson.annotation.JsonProperty;
 import dev.zarr.zarrjava.ZarrException;
 import dev.zarr.zarrjava.core.Attributes;
 
 import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
 
+@JsonIgnoreProperties(ignoreUnknown = true)
 public final class GroupMetadata extends dev.zarr.zarrjava.core.GroupMetadata {
 
   static final String NODE_TYPE = "group";

src/test/java/dev/zarr/zarrjava/ZarrPythonTests.java

@@ -414,7 +414,7 @@ public void testGroupReadWriteV2() throws Exception {
 
         array.write(testdata(dataType));
 
-        run_python_script("zarr_python_group_v2.py", storeHandle.toPath().toString(), storeHandle2.toPath().toString());
+        run_python_script("zarr_python_group_v2.py", storeHandle.toPath().toString(), storeHandle2.toPath().toString(), "" + 2);
 
         Group group2 = Group.open(storeHandle2);
         Assertions.assertEquals("value", group2.metadata().attributes().get("attr"));
@@ -426,4 +426,31 @@ public void testGroupReadWriteV2() throws Exception {
         Assertions.assertArrayEquals(new int[]{16, 16, 16}, result.getShape());
         assertIsTestdata(result, dataType);
     }
+
+    @Test
+    public void testGroupReadWriteV3() throws Exception {
+        StoreHandle storeHandle = new FilesystemStore(TESTOUTPUT).resolve("group_write");
+        StoreHandle storeHandle2 = new FilesystemStore(TESTOUTPUT).resolve("group_read");
+        dev.zarr.zarrjava.v3.Group group = dev.zarr.zarrjava.v3.Group.create(storeHandle, new Attributes(b -> b.set("attr", "value")));
+        dev.zarr.zarrjava.v3.DataType dataType = DataType.INT32;
+        dev.zarr.zarrjava.v3.Array array = group.createGroup("group").createArray("array", arrayMetadataBuilder -> arrayMetadataBuilder
+                .withShape(16, 16, 16)
+                .withDataType(dataType)
+                .withChunkShape(2, 4, 8)
+            );
+
+        array.write(testdata(dataType));
+
+        run_python_script("zarr_python_group_v2.py", storeHandle.toPath().toString(), storeHandle2.toPath().toString(), "" + 3);
+
+        dev.zarr.zarrjava.v3.Group group2 = dev.zarr.zarrjava.v3.Group.open(storeHandle2);
+        Assertions.assertEquals("value", group2.metadata().attributes().get("attr"));
+        dev.zarr.zarrjava.v3.Group subgroup = (dev.zarr.zarrjava.v3.Group) group2.get("group2");
+        Assertions.assertNotNull(subgroup);
+        dev.zarr.zarrjava.v3.Array array2 = (dev.zarr.zarrjava.v3.Array) subgroup.get("array2");
+        Assertions.assertNotNull(array2);
+        ucar.ma2.Array result = array2.read();
+        Assertions.assertArrayEquals(new int[]{16, 16, 16}, result.getShape());
+        assertIsTestdata(result, dataType);
+    }
 }

src/test/python-scripts/zarr_python_group_v2.py

@@ -7,17 +7,19 @@
 from zarr.storage import LocalStore
 
 store_path_read = Path(sys.argv[1])
+store_path_write = Path(sys.argv[2])
+zarr_format = int(sys.argv[3])
+assert zarr_format in (2,3), f"unexpected zarr format: {zarr_format}"
 
 expected_data = np.arange(16 * 16 * 16, dtype='int32').reshape(16, 16, 16)
 
-g = zarr.open_group(store=LocalStore(store_path_read), zarr_format=2)
+g = zarr.open_group(store=LocalStore(store_path_read), zarr_format=zarr_format)
 assert g.attrs['attr'] == 'value'
 a = g['group']['array']
 read_data = a[:, :]
 assert np.array_equal(read_data, expected_data), f"got:\n {read_data} \nbut expected:\n {expected_data}"
 
-store_path_write = Path(sys.argv[2])
-g2 = zarr.create_group(store=LocalStore(store_path_write), zarr_format=2)
+g2 = zarr.create_group(store=LocalStore(store_path_write), zarr_format=zarr_format)
 g2.attrs['attr'] = 'value'
 a2 = g2.create_group('group2').create_array(
     name='array2',