remove v3 code in v2

Author: brokkoli71

src/main/java/dev/zarr/zarrjava/core/codec/core/BytesCodec.java

@@ -0,0 +1,11 @@
+package dev.zarr.zarrjava.core.codec.core;
+
+import dev.zarr.zarrjava.core.codec.ArrayBytesCodec;
+
+public interface BytesCodec extends ArrayBytesCodec {
+
+    /*
+    TODO: better style would be to make this a class and dev.zarr.zarrjava.v3.codec.Codec an interface
+        Would this work with the serialization?
+     */
+}

src/main/java/dev/zarr/zarrjava/v2/Array.java

@@ -8,7 +8,7 @@
 import dev.zarr.zarrjava.core.codec.CodecPipeline;
 import dev.zarr.zarrjava.v2.codec.Codec;
 import dev.zarr.zarrjava.v2.codec.CodecRegistry;
-import dev.zarr.zarrjava.v3.codec.core.BytesCodec;
+import dev.zarr.zarrjava.v2.codec.core.BytesCodec;
 
 import javax.annotation.Nonnull;
 import java.io.IOException;

src/main/java/dev/zarr/zarrjava/v2/ArrayMetadata.java

@@ -47,7 +47,7 @@ public class ArrayMetadata implements dev.zarr.zarrjava.core.ArrayMetadata {
   public Codec compressor;
 
   @JsonIgnore
-  public dev.zarr.zarrjava.v3.ArrayMetadata.CoreArrayMetadata coreArrayMetadata;
+  public CoreArrayMetadata coreArrayMetadata;
 
 
   @JsonCreator(mode = JsonCreator.Mode.PROPERTIES)
@@ -78,7 +78,7 @@ public ArrayMetadata(
     this.filters = filters;
     this.compressor = compressor;
     this.coreArrayMetadata =
-        new dev.zarr.zarrjava.v3.ArrayMetadata.CoreArrayMetadata(shape, chunks,
+        new ArrayMetadata.CoreArrayMetadata(shape, chunks,
             this.dataType,
             parsedFillValue
         );

src/main/java/dev/zarr/zarrjava/v2/DataType.java

@@ -25,6 +25,7 @@ public enum DataType implements dev.zarr.zarrjava.core.DataType {
     this.endianness = endianness;
   }
 
+  //todo remove?
   public static DataType fromDataType(dev.zarr.zarrjava.v3.DataType dataType) {
     switch (dataType) {
       case BOOL:
@@ -58,6 +59,7 @@ public Endianness getEndianness() {
     return endianness;
   }
 
+  //todo remove?
   public dev.zarr.zarrjava.v3.DataType toV3() throws ZarrException {
     if (this.dtype.equals(BOOL.dtype))
       return dev.zarr.zarrjava.v3.DataType.BOOL;

src/main/java/dev/zarr/zarrjava/v2/Endianness.java

@@ -1,7 +1,7 @@
 package dev.zarr.zarrjava.v2;
 
 import com.fasterxml.jackson.annotation.JsonValue;
-import dev.zarr.zarrjava.v3.codec.core.BytesCodec;
+import dev.zarr.zarrjava.v2.codec.core.BytesCodec;
 
 public enum Endianness {
   LITTLE("<"),

src/main/java/dev/zarr/zarrjava/v2/codec/Codec.java

@@ -2,7 +2,7 @@
 
 import com.fasterxml.jackson.annotation.JsonTypeInfo;
 import dev.zarr.zarrjava.ZarrException;
-import dev.zarr.zarrjava.v3.ArrayMetadata;
+import dev.zarr.zarrjava.v2.ArrayMetadata;
 
 @JsonTypeInfo(use = JsonTypeInfo.Id.NAME, property = "id")
 public abstract class Codec implements dev.zarr.zarrjava.core.codec.Codec {

src/main/java/dev/zarr/zarrjava/v2/codec/core/BloscCodec.java

@@ -14,7 +14,7 @@
 import dev.zarr.zarrjava.ZarrException;
 import dev.zarr.zarrjava.utils.Utils;
 import dev.zarr.zarrjava.v2.codec.Codec;
-import dev.zarr.zarrjava.v3.ArrayMetadata;
+import dev.zarr.zarrjava.v2.ArrayMetadata;
 
 import javax.annotation.Nonnull;
 import java.io.IOException;

src/main/java/dev/zarr/zarrjava/v2/codec/core/BytesCodec.java

@@ -0,0 +1,72 @@
+package dev.zarr.zarrjava.v2.codec.core;
+
+import com.fasterxml.jackson.annotation.JsonCreator;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.annotation.JsonValue;
+import dev.zarr.zarrjava.ZarrException;
+import dev.zarr.zarrjava.v2.ArrayMetadata;
+import dev.zarr.zarrjava.v2.codec.Codec;
+import ucar.ma2.Array;
+
+import javax.annotation.Nonnull;
+import java.nio.ByteBuffer;
+import java.nio.ByteOrder;
+
+public class BytesCodec extends Codec implements dev.zarr.zarrjava.core.codec.core.BytesCodec {
+    @Nonnull
+    public final Endian endian;
+
+    public final String name = "bytes";
+
+    @JsonCreator
+    public BytesCodec(
+        @JsonProperty(value = "endian", defaultValue = "little") Endian endian) {
+        this.endian = endian;
+    }
+
+
+    @Override
+    public Array decode(ByteBuffer chunkBytes) {
+        chunkBytes.order(endian.getByteOrder());
+        return Array.factory(arrayMetadata.dataType.getMA2DataType(), arrayMetadata.chunkShape,
+            chunkBytes);
+    }
+
+    @Override
+    public ByteBuffer encode(Array chunkArray) {
+        return chunkArray.getDataAsByteBuffer(endian.getByteOrder());
+    }
+
+    @Override
+    public long computeEncodedSize(long inputByteLength,
+                                   ArrayMetadata.CoreArrayMetadata arrayMetadata) throws ZarrException {
+        return inputByteLength;
+    }
+
+    public enum Endian {
+        LITTLE("little"),
+        BIG("big");
+        private final String endian;
+
+        Endian(String endian) {
+            this.endian = endian;
+        }
+
+        @JsonValue
+        public String getValue() {
+            return endian;
+        }
+
+        public ByteOrder getByteOrder() {
+            switch (this) {
+                case LITTLE:
+                    return ByteOrder.LITTLE_ENDIAN;
+                case BIG:
+                    return ByteOrder.BIG_ENDIAN;
+                default:
+                    throw new RuntimeException("Unreachable");
+            }
+        }
+    }
+}
+

src/main/java/dev/zarr/zarrjava/v3/codec/core/BytesCodec.java

@@ -12,7 +12,7 @@
 import javax.annotation.Nonnull;
 import ucar.ma2.Array;
 
-public class BytesCodec extends Codec implements ArrayBytesCodec {
+public class BytesCodec extends Codec implements dev.zarr.zarrjava.core.codec.core.BytesCodec {
 
   public final String name = "bytes";
   @Nonnull