check for sharding bounds in metadata creation

Author: brokkoli71

src/main/java/dev/zarr/zarrjava/v3/ArrayMetadata.java

@@ -10,9 +10,12 @@
 import dev.zarr.zarrjava.v3.chunkgrid.RegularChunkGrid;
 import dev.zarr.zarrjava.v3.chunkkeyencoding.ChunkKeyEncoding;
 import dev.zarr.zarrjava.v3.codec.Codec;
+import dev.zarr.zarrjava.v3.codec.core.ShardingIndexedCodec;
+
 import java.nio.ByteBuffer;
 import java.util.Arrays;
 import java.util.Map;
+import java.util.Optional;
 import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
 
@@ -91,6 +94,35 @@ public ArrayMetadata(
           "Expected node type '" + this.nodeType + "', got '" + nodeType + "'.");
     }
 
+    if (chunkGrid instanceof RegularChunkGrid) {
+      int[] chunkShape = ((RegularChunkGrid) chunkGrid).configuration.chunkShape;
+      if (shape.length != chunkShape.length) {
+        throw new ZarrException("Shape (ndim=" + shape.length + ") and chunk shape (ndim=" +
+            chunkShape.length + ") need to have the same number of dimensions.");
+      }
+      for (int i = 0; i < shape.length; i++) {
+        if (shape[i] < chunkShape[i]) {
+          throw new ZarrException("Shape " + Arrays.toString(shape) + " can not contain chunk shape "
+              + Arrays.toString(chunkShape));
+        }
+      }
+
+      Optional<Codec> shardingCodec = getShardingIndexedCodec(codecs);
+      int[] outerChunkShape = chunkShape;
+      while (shardingCodec.isPresent()) {
+        ShardingIndexedCodec.Configuration shardingConfig = ((ShardingIndexedCodec) shardingCodec.get()).configuration;
+        int[] innerChunkShape = shardingConfig.chunkShape;
+        if (outerChunkShape.length != innerChunkShape.length)
+          throw new ZarrException("Sharding dimensions mismatch of outer chunk shape " + Arrays.toString(outerChunkShape) + " and inner chunk shape" + Arrays.toString(innerChunkShape));
+        for (int i = 0; i < outerChunkShape.length; i++) {
+          if (outerChunkShape[i] < innerChunkShape[i])
+            throw new ZarrException("Sharding outer chunk shape " + Arrays.toString(outerChunkShape) + " can not contain inner chunk shape " + Arrays.toString(innerChunkShape));
+        }
+        outerChunkShape = innerChunkShape;
+        shardingCodec = getShardingIndexedCodec(shardingConfig.codecs);
+      }
+    }
+
     this.shape = shape;
     this.dataType = dataType;
     this.chunkGrid = chunkGrid;
@@ -227,6 +259,10 @@ public int ndim() {
     return shape.length;
   }
 
+  public static Optional<Codec> getShardingIndexedCodec(Codec[] codecs) {
+    return Arrays.stream(codecs).filter(codec -> codec instanceof ShardingIndexedCodec).findFirst();
+  }
+
   public int[] chunkShape() {
     return ((RegularChunkGrid) this.chunkGrid).configuration.chunkShape;
   }

src/main/java/dev/zarr/zarrjava/v3/ArrayMetadataBuilder.java

@@ -126,22 +126,6 @@ public ArrayMetadataBuilder withAttributes(Map<String, Object> attributes) {
     return this;
   }
 
-  public void verifyShardingBounds(int[] outerChunkShape, Codec[] codecs) throws ZarrException {
-    for (Codec codec : codecs) {
-      if (codec instanceof ShardingIndexedCodec) {
-        ShardingIndexedCodec.Configuration shardingConfig = ((ShardingIndexedCodec) codec).configuration;
-        int[] innerChunkShape = shardingConfig.chunkShape;
-        if (outerChunkShape.length != innerChunkShape.length)
-          throw new ZarrException("Sharding dimensions mismatch of outer chunk shape " + Arrays.toString(outerChunkShape) + " and inner chunk shape" + Arrays.toString(innerChunkShape));
-        for (int i = 0; i < outerChunkShape.length; i++) {
-          if (outerChunkShape[i] < innerChunkShape[i])
-            throw new ZarrException("Sharding outer chunk shape " + Arrays.toString(outerChunkShape) + " can not contain inner chunk shape " + Arrays.toString(innerChunkShape));
-        }
-        verifyShardingBounds(innerChunkShape, shardingConfig.codecs);
-      }
-    }
-  }
-
   public ArrayMetadata build() throws ZarrException {
     if (shape == null) {
       throw new ZarrException("Shape needs to be provided. Please call `.withShape`.");
@@ -152,20 +136,7 @@ public ArrayMetadata build() throws ZarrException {
     if (chunkGrid == null) {
       throw new ZarrException("Chunk grid needs to be provided. Please call `.withChunkShape`.");
     }
-    if (chunkGrid instanceof RegularChunkGrid) {
-      int[] chunkShape = ((RegularChunkGrid) chunkGrid).configuration.chunkShape;
-      if (shape.length != chunkShape.length) {
-        throw new ZarrException("Shape (ndim=" + shape.length + ") and chunk shape (ndim=" +
-            chunkShape.length + ") need to have the same number of dimensions.");
-      }
-      for (int i = 0; i < shape.length; i++) {
-        if (shape[i] < chunkShape[i]) {
-          throw new ZarrException("Shape " + Arrays.toString(shape) + " can not contain chunk shape "
-              + Arrays.toString(chunkShape));
-        }
-      }
-      verifyShardingBounds(chunkShape, codecs);
-    }
+
 
     return new ArrayMetadata(shape, dataType, chunkGrid, chunkKeyEncoding, fillValue, codecs,
         dimensionNames,