ArrayMetadata.shape: long vs Array.read: int

[dominikl]

Just a minor issue (or is it intentional?): Just noticed that the shape metadata is a long array https://github.com/zarr-developers/zarr-java/blob/main/src/main/java/dev/zarr/zarrjava/core/ArrayMetadata.java#L17 but in Array.read you have to provide an int array for the shape argument https://github.com/zarr-developers/zarr-java/blob/main/src/main/java/dev/zarr/zarrjava/core/Array.java#L230 .

[brokkoli71]

Thanks for the feedback!
I think both shape and offset should be of type long[].
What do you think @normanrz?

[normanrz]

Because the read/write shape is bounded by the max size of arrays in Java, int should suffice. Zarr arrays shape can be arbitrarily large, so long is required for the offset.
I can see that using the same type has some appeal. How is this in jzarr?

[brokkoli71]

in JZarr its public Object read(int[] shape, int[] offset)

[normanrz]

Maybe using longs all the way is the best way forward.