Apply ruff/Perflint rule PERF401

PERF401 Use an async list comprehension to create a transformed list

Author: DimitriPapadopoulos

tests/v3/conftest.py

@@ -105,7 +105,7 @@ def xp(request: pytest.FixtureRequest) -> Iterator[ModuleType]:
     if request.param == "cupy":
         request.node.add_marker(pytest.mark.gpu)
 
-    yield pytest.importorskip(request.param)
+    return pytest.importorskip(request.param)
 
 
 @pytest.fixture(autouse=True)

tests/v3/test_indexing.py

@@ -36,7 +36,7 @@
 
 @pytest.fixture
 async def store() -> AsyncGenerator[StorePath]:
-    yield StorePath(await MemoryStore.open(mode="w"))
+    return StorePath(await MemoryStore.open(mode="w"))
 
 
 def zarr_array_from_numpy_array(
@@ -1782,9 +1782,9 @@ async def test_accessed_chunks(
 
         # Combine and generate the cartesian product to determine the chunks keys that
         # will be accessed
-        chunks_accessed = []
-        for comb in itertools.product(*chunks_per_dim):
-            chunks_accessed.append(".".join([str(ci) for ci in comb]))
+        chunks_accessed = [
+            ".".join([str(ci) for ci in comb]) for comb in itertools.product(*chunks_per_dim)
+        ]
 
         counts_before = store.counter.copy()
 

tests/v3/test_store/test_remote.py

@@ -86,10 +86,7 @@ def s3(s3_base: None) -> Generator[s3fs.S3FileSystem, None, None]:
 
 
 async def alist(it):
-    out = []
-    async for a in it:
-        out.append(a)
-    return out
+    return [a async for a in it]
 
 
 async def test_basic() -> None:

tests/v3/test_v2.py

@@ -9,7 +9,7 @@
 
 @pytest.fixture
 async def store() -> Iterator[StorePath]:
-    yield StorePath(await MemoryStore.open(mode="w"))
+    return StorePath(await MemoryStore.open(mode="w"))
 
 
 def test_simple(store: StorePath) -> None: