R1728: Redundant list comprehension can be replaced using generator

Removing [] inside calls that can use containers or generators should
be considered for performance reasons since a generator will have an
upfront cost to pay. The performance will be better if you are working
with long lists or sets.

Author: DimitriPapadopoulos

tests/test_group.py

@@ -1627,12 +1627,10 @@ async def test_create_hierarchy_existing_nodes(
     elif impl == "async":
         with pytest.raises(err_cls, match=re.escape(msg)):
             tuple(
-                [
-                    x
-                    async for x in create_hierarchy(
-                        store=store, nodes={"node": new_metadata}, overwrite=False
-                    )
-                ]
+                x
+                async for x in create_hierarchy(
+                    store=store, nodes={"node": new_metadata}, overwrite=False
+                )
             )
     else:
         raise ValueError(f"Invalid impl: {impl}")

tests/test_store/test_core.py

@@ -195,7 +195,7 @@ def test_valid() -> None:
         Test that path normalization works as expected
         """
         paths = ["a", "b", "c", "d", "", "//a///b//"]
-        assert _normalize_paths(paths) == tuple([normalize_path(p) for p in paths])
+        assert _normalize_paths(paths) == tuple(normalize_path(p) for p in paths)
 
     @staticmethod
     @pytest.mark.parametrize("paths", [("", "/"), ("///a", "a")])