much simpler test

Author: dcherian

src/zarr/core/codec_pipeline.py

@@ -309,7 +309,7 @@ def _merge_chunk_array(
                     for idx in range(chunk_spec.ndim)
                 )
                 chunk_value = chunk_value[item]
-        if is_complete_chunk:
+        if is_complete_chunk and chunk_value.shape == chunk_spec.shape:
             # TODO: For the last chunk, we could have is_complete_chunk=True
             #       that is smaller than the chunk_spec.shape but this throws
             #       an error in the _decode_single

tests/test_array.py

@@ -829,32 +829,6 @@ def test_append_bad_shape(store: MemoryStore, zarr_format: ZarrFormat) -> None:
         z.append(b)
 
 
-def test_append_shape_not_equals_chunk_shape() -> None:
-    # regression test for GH2849
-    g = zarr.open("foo.zarr", zarr_format=3, mode="w")
-    g["bar"] = np.arange(3)
-
-    size = 4
-    data = [0, 1, 2, 3]
-    g["bar"].append(data)
-    assert (g["bar"][-size:] == data).all(), (g["bar"][-size:], data)
-
-    size = 3
-    data = [-1, -2, -3]
-    g["bar"].append(data)
-    assert (g["bar"][-size:] == data).all(), (g["bar"][-size:], data)
-
-    size = 2
-    data = [-10, -11]
-    g["bar"].append(data)
-    assert (g["bar"][-size:] == data).all(), (g["bar"][-size:], data)
-
-    size = 3
-    data = [-4, -5, -6]
-    g["bar"].append(data)
-    assert (g["bar"][-size:] == data).all(), (g["bar"][-size:], data)
-
-
 @pytest.mark.parametrize("store", ["memory"], indirect=True)
 @pytest.mark.parametrize("write_empty_chunks", [True, False])
 @pytest.mark.parametrize("fill_value", [0, 5])

tests/test_indexing.py

@@ -815,6 +815,15 @@ def test_set_orthogonal_selection_1d(store: StorePath) -> None:
         _test_set_orthogonal_selection(v, a, z, selection)
 
 
+def test_set_orthogonal_selection_1d_last_two_chunks():
+    # regression test for GH2849
+    g = zarr.open_group("foo.zarr", zarr_format=3, mode="w")
+    a = g.create_array("bar", shape=(10,), chunks=(3,), dtype=int)
+    data = np.array([7, 8, 9])
+    a[slice(7, 10)] = data
+    np.testing.assert_array_equal(a[slice(7, 10)], data)
+
+
 def _test_set_orthogonal_selection_2d(
     v: npt.NDArray[np.int_],
     a: npt.NDArray[np.int_],