windows fix

Author: jhamman

src/zarr/storage/_zep8.py

@@ -8,6 +8,7 @@
 
 from __future__ import annotations
 
+import re
 from typing import TYPE_CHECKING, Any
 from urllib.parse import urlparse
 
@@ -83,6 +84,11 @@ def parse(self, url: str) -> list[URLSegment]:
 
         return segments
 
+    @staticmethod
+    def _is_windows_path(url: str) -> bool:
+        r"""Check if URL is a Windows absolute path like C:\... or C:/..."""
+        return re.match(r"^[A-Za-z]:[/\\]", url) is not None
+
     @staticmethod
     def _parse_base_url(url: str) -> URLSegment:
         """Parse the base URL component."""
@@ -94,6 +100,9 @@ def _parse_base_url(url: str) -> URLSegment:
                 return URLSegment(scheme="file", path=parsed.path)
             else:
                 return URLSegment(scheme=parsed.scheme, path=f"{parsed.netloc}{parsed.path}")
+        elif URLParser._is_windows_path(url):
+            # Windows absolute path like C:\... or C:/... - treat as filesystem path
+            return URLSegment(scheme="file", path=url)
         elif ":" in url:
             # Adapter syntax like "memory:", "zip:path", etc.
             adapter, path = url.split(":", 1)

tests/test_store/test_zep8.py

@@ -5,6 +5,7 @@
 Tests are organized by functionality groups rather than classes.
 """
 
+import tempfile
 import zipfile
 from pathlib import Path
 from typing import Any
@@ -1202,15 +1203,16 @@ async def test_filesystem_adapter_edge_cases() -> None:
     store = await FileSystemAdapter.from_url_segment(segment, "file:")
     assert store is not None
 
-    # Test with mode specified in kwargs
+    # Test with mode specified in kwargs - use cross-platform temp directory
+    temp_dir = tempfile.gettempdir()
     segment = URLSegment(adapter="file")
-    store = await FileSystemAdapter.from_url_segment(segment, "file:/tmp", mode="r")
+    store = await FileSystemAdapter.from_url_segment(segment, f"file:{temp_dir}", mode="r")
     assert store.read_only
 
     # Test with read_only in storage_options
     segment = URLSegment(adapter="file")
     store = await FileSystemAdapter.from_url_segment(
-        segment, "file:/tmp", storage_options={"read_only": True}
+        segment, f"file:{temp_dir}", storage_options={"read_only": True}
     )
     assert store.read_only