Simplify if/else statement (#1227)

Author: DimitriPapadopoulos

docs/release.rst

@@ -17,6 +17,9 @@ Unreleased
 Maintenance
 ~~~~~~~~~~~
 
+* Simplify if/else statement.
+  By :user:`Dimitri Papadopoulos Orfanos <DimitriPapadopoulos>` :issue:`1227`.
+
 * Migrate to ``pyproject.toml`` and remove redundant infrastructure.
   By :user:`Saransh Chopra <Saransh-cpp>` :issue:`1158`.
 

zarr/convenience.py

@@ -487,12 +487,11 @@ def __init__(self, log):
         elif isinstance(log, str):
             self.log_file = io.open(log, mode='w')
             self.needs_closing = True
-        else:
-            if not hasattr(log, 'write'):
-                raise TypeError('log must be a callable function, file path or '
-                                'file-like object, found %r' % log)
+        elif hasattr(log, 'write'):
             self.log_file = log
-            self.needs_closing = False
+        else:
+            raise TypeError('log must be a callable function, file path or '
+                            'file-like object, found %r' % log)
 
     def __enter__(self):
         return self