Skip to content

Commit 2b1e90b

Browse files
committed
fixup tests
1 parent b6e8935 commit 2b1e90b

File tree

1 file changed

+16
-4
lines changed

1 file changed

+16
-4
lines changed

tests/v3/test_group.py

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
from __future__ import annotations
22

3+
import contextlib
34
import pickle
45
import warnings
56
from typing import TYPE_CHECKING, Any, Literal, cast
@@ -178,22 +179,33 @@ def test_group_members(store: Store, zarr_format: ZarrFormat, consolidated_metad
178179
)
179180
)
180181

182+
# this warning shows up when extra objects show up in the hierarchy
183+
warn_context = pytest.warns(
184+
UserWarning, match=r"Object at .* is not recognized as a component of a Zarr hierarchy."
185+
)
181186
if consolidated_metadata:
182-
zarr.consolidate_metadata(store=store, zarr_format=zarr_format)
187+
with warn_context:
188+
zarr.consolidate_metadata(store=store, zarr_format=zarr_format)
189+
# now that we've consolidated the store, we shouldn't get the warnings from the unrecognized objects anymore
190+
# we use a nullcontext to handle these cases
191+
warn_context = contextlib.nullcontext()
183192
group = zarr.open_consolidated(store=store, zarr_format=zarr_format)
184193

185-
members_observed = group.members()
194+
with warn_context:
195+
members_observed = group.members()
186196
# members are not guaranteed to be ordered, so sort before comparing
187197
assert sorted(dict(members_observed)) == sorted(members_expected)
188198

189199
# partial
190-
members_observed = group.members(max_depth=1)
200+
with warn_context:
201+
members_observed = group.members(max_depth=1)
191202
members_expected["subgroup/subsubgroup"] = subsubgroup
192203
# members are not guaranteed to be ordered, so sort before comparing
193204
assert sorted(dict(members_observed)) == sorted(members_expected)
194205

195206
# total
196-
members_observed = group.members(max_depth=None)
207+
with warn_context:
208+
members_observed = group.members(max_depth=None)
197209
members_expected["subgroup/subsubgroup/subsubsubgroup"] = subsubsubgroup
198210
# members are not guaranteed to be ordered, so sort before comparing
199211
assert sorted(dict(members_observed)) == sorted(members_expected)

0 commit comments

Comments
 (0)