Skip to content

Commit 2eaa79d

Browse files
committed
improve test readability
1 parent 4deec1c commit 2eaa79d

File tree

1 file changed

+18
-16
lines changed

1 file changed

+18
-16
lines changed

tests/test_api.py

Lines changed: 18 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -133,28 +133,30 @@ async def test_open_group_unspecified_version(
133133

134134

135135
@pytest.mark.parametrize("store", ["local", "memory", "zip"], indirect=["store"])
136-
@pytest.mark.parametrize("n_args", [2, 1, 0])
137-
@pytest.mark.parametrize("n_kwargs", [2, 1, 0])
136+
@pytest.mark.parametrize("n_args", [10, 1, 0])
137+
@pytest.mark.parametrize("n_kwargs", [10, 1, 0])
138138
def test_save(store: Store, n_args: int, n_kwargs: int) -> None:
139139
data = np.arange(10)
140+
140141
if n_kwargs == 0 and n_args == 0:
141142
with pytest.raises(ValueError):
142143
save(store)
143-
return
144-
args = [np.arange(10) for _ in range(n_args)]
145-
kwargs = {f"arg_{i}": data for i in range(n_kwargs)}
146-
save(store, *args, **kwargs)
147-
# open arrays
148-
if n_args == 1 and n_kwargs == 0:
149-
a = open(store)
150-
assert isinstance(a, Array)
151-
assert_array_equal(a, data)
144+
elif n_args == 1 and n_kwargs == 0:
145+
save(store, data)
146+
array = open(store)
147+
assert isinstance(array, Array)
148+
assert_array_equal(array, data)
152149
else:
153-
g = open(store)
154-
assert isinstance(g, Group)
155-
for a in g.array_values():
156-
assert_array_equal(a, data)
157-
assert g.nmembers() == n_args + n_kwargs
150+
args = [np.arange(10) for _ in range(n_args)]
151+
kwargs = {f"arg_{i}": data for i in range(n_kwargs)}
152+
save(store, *args, **kwargs)
153+
group = open(store)
154+
assert isinstance(group, Group)
155+
for array in group.array_values():
156+
assert_array_equal(array[:], data)
157+
for k in kwargs.keys():
158+
assert k in group
159+
assert group.nmembers() == n_args + n_kwargs
158160

159161

160162
def test_save_errors() -> None:

0 commit comments

Comments
 (0)