tests

Author: normanrz

src/zarr/core/array.py

@@ -680,10 +680,10 @@ async def _create_v2(
             dimension_separator = "."
 
         dtype = parse_dtype(dtype, zarr_format=2)
-        # if not filters:
-        #     filters = _default_filters(dtype)
-        # if not compressor:
-        #     compressor = _default_compressor(dtype)
+        if not filters:
+            filters = _default_filters(dtype)
+        if not compressor:
+            compressor = _default_compressor(dtype)
 
         # inject VLenUTF8 for str dtype if not already present
         if np.issubdtype(dtype, np.str_):
@@ -3528,10 +3528,10 @@ async def create_array(
     dtype: npt.DTypeLike,
     chunks: ChunkCoords | Literal["auto"] = "auto",
     shards: ShardsParam | None = None,
-    filters: FiltersParam = "auto",
+    filters: FiltersParam | None = "auto",
     compressors: CompressorsParam = "auto",
-    array_bytes_codec: ArrayBytesCodecParam | None = "auto",
-    fill_value: Any | None = 0,
+    array_bytes_codec: ArrayBytesCodecParam = "auto",
+    fill_value: Any | None = None,
     order: MemoryOrder | None = None,
     zarr_format: ZarrFormat | None = 3,
     attributes: dict[str, JSON] | None = None,
@@ -3665,6 +3665,9 @@ async def create_array(
             )
 
             raise ValueError(msg)
+        if array_bytes_codec != "auto":
+            raise ValueError("Zarr v2 arrays do not support `array_bytes_codec`.")
+
         filters_parsed, compressor_parsed = _parse_chunk_encoding_v2(
             compressor=compressors, filters=filters, dtype=np.dtype(dtype)
         )
@@ -3825,7 +3828,7 @@ def _get_default_chunk_encoding_v2(
 def _parse_chunk_encoding_v2(
     *,
     compressor: CompressorsParam,
-    filters: FiltersParam,
+    filters: FiltersParam | None,
     dtype: np.dtype[Any],
 ) -> tuple[tuple[numcodecs.abc.Codec, ...] | None, numcodecs.abc.Codec | None]:
     """
@@ -3839,11 +3842,7 @@ def _parse_chunk_encoding_v2(
     if compressor == "auto":
         _compressor = default_compressor
     else:
-        if (
-            isinstance(compressor, Iterable)
-            and not isinstance(compressor, dict)
-            and len(compressor) > 1
-        ):
+        if isinstance(compressor, Iterable) and not isinstance(compressor, dict):
             msg = f"For Zarr v2 arrays, the `compressor` must be a single codec. Got an iterable with type {type(compressor)} instead."
             raise TypeError(msg)
         _compressor = parse_compressor(compressor)
@@ -3866,7 +3865,7 @@ def _parse_chunk_encoding_v3(
     *,
     compressors: CompressorsParam | None,
     filters: FiltersParam | None,
-    array_bytes_codec: ArrayBytesCodecParam | None,
+    array_bytes_codec: ArrayBytesCodecParam,
     dtype: np.dtype[Any],
 ) -> tuple[tuple[ArrayArrayCodec, ...], ArrayBytesCodec, tuple[BytesBytesCodec, ...]]:
     """

src/zarr/core/metadata/v2.py

@@ -232,8 +232,6 @@ def parse_filters(data: object) -> tuple[numcodecs.abc.Codec, ...] | None:
     if data is None:
         return data
     if isinstance(data, Iterable):
-        if len(data) == 0:
-            return None
         for idx, val in enumerate(data):
             if isinstance(val, numcodecs.abc.Codec):
                 out.append(val)
@@ -251,11 +249,6 @@ def parse_compressor(data: object) -> numcodecs.abc.Codec | None:
     """
     Parse a potential compressor.
     """
-    if isinstance(data, Iterable) and not isinstance(data, dict):
-        if len(data) == 0:
-            data = None
-        else:
-            data = data[0]
     if data is None or isinstance(data, numcodecs.abc.Codec):
         return data
     if isinstance(data, dict):

src/zarr/registry.py

@@ -200,6 +200,8 @@ def _parse_array_bytes_codec(data: dict[str, JSON] | Codec) -> ArrayBytesCodec:
             msg = f"Expected a dict representation of a ArrayBytesCodec; got a dict representation of a {type(result)} instead."
             raise TypeError(msg)
     else:
+        if not isinstance(data, ArrayBytesCodec):
+            raise TypeError(f"Expected a ArrayBytesCodec. Got {type(data)} instead.")
         result = data
     return result
 

tests/test_array.py

@@ -219,7 +219,7 @@ def test_array_v3_fill_value(store: MemoryStore, fill_value: int, dtype_str: str
 def test_create_positional_args_deprecated() -> None:
     store = MemoryStore()
     with pytest.warns(FutureWarning, match="Pass"):
-        zarr.create_array(store, (2, 2), dtype="f8")
+        zarr.Array._create(store, (2, 2), dtype="f8")
 
 
 def test_selection_positional_args_deprecated() -> None:
@@ -994,6 +994,17 @@ async def test_create_array_no_filters_compressors(store: MemoryStore, dtype: st
     """
 
     # v2
+    arr = await create_array(
+        store=store,
+        dtype=dtype,
+        shape=(10,),
+        zarr_format=2,
+        compressors=None,
+        filters=None,
+    )
+    assert arr.metadata.filters is None  # type: ignore[union-attr]
+    assert arr.metadata.compressor is None  # type: ignore[union-attr]
+
     arr = await create_array(
         store=store,
         dtype=dtype,
@@ -1002,8 +1013,8 @@ async def test_create_array_no_filters_compressors(store: MemoryStore, dtype: st
         compressors=(),
         filters=(),
     )
-    assert arr.metadata.filters == None  # type: ignore[union-attr]
-    assert arr.metadata.compressor == None  # type: ignore[union-attr]
+    assert arr.metadata.filters == ()  # type: ignore[union-attr]
+    assert arr.metadata.compressor is None  # type: ignore[union-attr]
 
     # v3
     arr = await create_array(

tests/test_codecs/test_endian.py

@@ -3,7 +3,6 @@
 import numpy as np
 import pytest
 
-from zarr import AsyncArray
 import zarr
 from zarr.abc.store import Store
 from zarr.codecs import BytesCodec

tests/test_codecs/test_sharding.py

@@ -297,8 +297,10 @@ async def test_delete_empty_shards(store: Store) -> None:
         chunks=(8, 8),
         shards=(8, 16),
         dtype="uint16",
+        compressors=None,
         fill_value=1,
     )
+    print(a.metadata.to_dict())
     await _AsyncArrayProxy(a)[:, :].set(np.zeros((16, 16)))
     await _AsyncArrayProxy(a)[8:, :].set(np.ones((8, 16)))
     await _AsyncArrayProxy(a)[:, 8:].set(np.ones((16, 8)))