Raise not implemented error on pickling

Author: maxrjones

src/zarr/storage/object_store.py

@@ -69,6 +69,12 @@ def __str__(self) -> str:
     def __repr__(self) -> str:
         return f"ObjectStore({self})"
 
+    def __getstate__(self) -> None:
+        raise NotImplementedError("Pickling has not been implement for ObjectStore")
+
+    def __setstate__(self) -> None:
+        raise NotImplementedError("Pickling has not been implement for ObjectStore")
+
     async def get(
         self, key: str, prototype: BufferPrototype, byte_range: ByteRequest | None = None
     ) -> Buffer:

tests/test_store/test_object.py

@@ -3,6 +3,7 @@
 
 obstore = pytest.importorskip("obstore")
 
+import pickle
 import re
 
 from zarr.core.buffer import Buffer, cpu
@@ -51,3 +52,8 @@ def test_store_supports_partial_writes(self, store: ObjectStore) -> None:
 
     def test_store_supports_listing(self, store: ObjectStore) -> None:
         assert store.supports_listing
+
+    @pytest.mark.xfail(reason="Not Implemented")
+    def test_serializable_store(self, store: ObjectStore) -> None:
+        foo = pickle.dumps(store)
+        assert pickle.loads(foo) == store