18
18
from zarr .core .buffer import default_buffer_prototype
19
19
from zarr .registry import get_store_adapter , register_store_adapter
20
20
from zarr .storage import FsspecStore , LocalStore , LoggingStore , MemoryStore , ZipStore
21
- from zarr .storage ._builtin_adapters import GCSAdapter , HttpsAdapter , LoggingAdapter , S3Adapter
21
+ from zarr .storage ._builtin_adapters import GSAdapter , HttpsAdapter , LoggingAdapter , S3Adapter
22
22
from zarr .storage ._common import make_store_path
23
23
from zarr .storage ._zep8 import URLParser , URLStoreResolver , ZEP8URLError , is_zep8_url
24
24
@@ -428,8 +428,8 @@ def test_fsspec_store_adapters_registered() -> None:
428
428
https_adapter = get_store_adapter ("https" )
429
429
assert https_adapter is not None
430
430
431
- gcs_adapter = get_store_adapter ("gcs " )
432
- assert gcs_adapter is not None
431
+ gs_adapter = get_store_adapter ("gs " )
432
+ assert gs_adapter is not None
433
433
434
434
435
435
async def test_fsspec_s3_url_resolution () -> None :
@@ -496,7 +496,7 @@ async def test_make_store_path_with_fsspec_urls() -> None:
496
496
497
497
# Test that fsspec URLs still work with make_store_path
498
498
# Note: These will fail to connect but should parse correctly
499
- fsspec_urls = ["s3://bucket/path" , "gcs ://bucket/path" , "https://example.com/data" ]
499
+ fsspec_urls = ["s3://bucket/path" , "gs ://bucket/path" , "https://example.com/data" ]
500
500
501
501
for url in fsspec_urls :
502
502
# These should not be detected as ZEP 8 URLs
@@ -514,7 +514,7 @@ def test_fsspec_zep8_url_detection() -> None:
514
514
zep8_urls = [
515
515
"s3://bucket/data.zip|zip:" ,
516
516
"https://example.com/data|zip:|zarr3:" ,
517
- "gcs ://bucket/data.zarr|zarr2:" ,
517
+ "gs ://bucket/data.zarr|zarr2:" ,
518
518
]
519
519
520
520
for url in zep8_urls :
@@ -524,7 +524,7 @@ def test_fsspec_zep8_url_detection() -> None:
524
524
regular_urls = [
525
525
"s3://bucket/data.zarr" ,
526
526
"https://example.com/data.zarr" ,
527
- "gcs ://bucket/data" ,
527
+ "gs ://bucket/data" ,
528
528
]
529
529
530
530
for url in regular_urls :
@@ -574,10 +574,10 @@ def test_fsspec_schemes_support() -> None:
574
574
assert set (HttpsAdapter .get_supported_schemes ()) == {"http" , "https" }
575
575
576
576
# Test GCS adapter
577
- assert GCSAdapter .can_handle_scheme ("gcs " )
578
- # GCS adapter supports both gcs:// and gs:// schemes
579
- supported_schemes = GCSAdapter .get_supported_schemes ()
580
- assert "gcs" in supported_schemes or " gs" in supported_schemes
577
+ assert GSAdapter .can_handle_scheme ("gs " )
578
+ # GCS adapter only supports gs:// scheme
579
+ supported_schemes = GSAdapter .get_supported_schemes ()
580
+ assert "gs" in supported_schemes
581
581
582
582
583
583
async def test_fsspec_url_chain_parsing () -> None :
@@ -590,7 +590,7 @@ async def test_fsspec_url_chain_parsing() -> None:
590
590
complex_urls = [
591
591
"s3://bucket/archive.zip|zip:data/|zarr3:group" ,
592
592
"https://example.com/data.tar.gz|tar:|zip:|zarr2:" ,
593
- "gcs ://bucket/dataset.zarr|zarr3:array/subarray" ,
593
+ "gs ://bucket/dataset.zarr|zarr3:array/subarray" ,
594
594
]
595
595
596
596
for url in complex_urls :
@@ -1236,27 +1236,16 @@ async def test_s3_adapter_functionality() -> None:
1236
1236
1237
1237
1238
1238
async def test_gcs_adapter_functionality () -> None :
1239
- """Test GCSAdapter functionality."""
1240
- from zarr .storage ._builtin_adapters import GCSAdapter
1239
+ """Test GSAdapter functionality."""
1241
1240
1242
1241
# Test can_handle_scheme
1243
- assert GCSAdapter .can_handle_scheme ("gs" )
1244
- assert GCSAdapter .can_handle_scheme ("gcs" )
1245
- assert not GCSAdapter .can_handle_scheme ("s3" )
1242
+ assert GSAdapter .can_handle_scheme ("gs" )
1243
+ assert not GSAdapter .can_handle_scheme ("s3" )
1246
1244
1247
1245
# Test get_supported_schemes
1248
- schemes = GCSAdapter .get_supported_schemes ()
1249
- assert "gs" in schemes
1250
- assert "gcs" in schemes
1251
-
1252
-
1253
- async def test_gs_adapter_functionality () -> None :
1254
- """Test GSAdapter (alias) functionality."""
1255
- from zarr .storage ._builtin_adapters import GSAdapter
1256
-
1257
- # GSAdapter is an alias for GCSAdapter
1258
1246
schemes = GSAdapter .get_supported_schemes ()
1259
1247
assert "gs" in schemes
1248
+ assert len (schemes ) == 1 # Should only support gs now
1260
1249
1261
1250
1262
1251
async def test_https_adapter_functionality () -> None :
@@ -1351,7 +1340,6 @@ def test_builtin_adapters_imports_and_module_structure() -> None:
1351
1340
# Test that all adapter classes can be imported
1352
1341
from zarr .storage ._builtin_adapters import (
1353
1342
FileSystemAdapter ,
1354
- GCSAdapter ,
1355
1343
GSAdapter ,
1356
1344
HttpsAdapter ,
1357
1345
LoggingAdapter ,
@@ -1366,16 +1354,14 @@ def test_builtin_adapters_imports_and_module_structure() -> None:
1366
1354
assert MemoryAdapter .adapter_name == "memory"
1367
1355
assert RemoteAdapter .adapter_name == "remote"
1368
1356
assert S3Adapter .adapter_name == "s3"
1369
- assert GCSAdapter .adapter_name == "gcs"
1370
1357
assert GSAdapter .adapter_name == "gs"
1371
1358
assert HttpsAdapter .adapter_name == "https"
1372
1359
assert LoggingAdapter .adapter_name == "log"
1373
1360
assert ZipAdapter .adapter_name == "zip"
1374
1361
1375
1362
# Test inheritance relationships
1376
1363
assert issubclass (S3Adapter , RemoteAdapter )
1377
- assert issubclass (GCSAdapter , RemoteAdapter )
1378
- assert issubclass (GSAdapter , GCSAdapter )
1364
+ assert issubclass (GSAdapter , RemoteAdapter )
1379
1365
assert issubclass (HttpsAdapter , RemoteAdapter )
1380
1366
1381
1367
0 commit comments