Skip to content

Commit 48c8e3b

Browse files
committed
make signatures consistent
1 parent 1f57492 commit 48c8e3b

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

src/zarr/api/asynchronous.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
from zarr.abc.store import Store
1313
from zarr.core.array import (
14+
DEFAULT_FILL_VALUE,
1415
Array,
1516
AsyncArray,
1617
CompressorLike,
@@ -863,7 +864,7 @@ async def create(
863864
chunks: ChunkCoords | int | bool | None = None,
864865
dtype: ZDTypeLike | None = None,
865866
compressor: CompressorLike = "auto",
866-
fill_value: Any | None = None, # TODO: need type
867+
fill_value: Any | None = DEFAULT_FILL_VALUE,
867868
order: MemoryOrder | None = None,
868869
store: str | StoreLike | None = None,
869870
synchronizer: Any | None = None,

src/zarr/core/group.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
from zarr.abc.store import Store, set_or_delete
2121
from zarr.core._info import GroupInfo
2222
from zarr.core.array import (
23+
DEFAULT_FILL_VALUE,
2324
Array,
2425
AsyncArray,
2526
CompressorLike,
@@ -1009,7 +1010,7 @@ async def create_array(
10091010
compressors: CompressorsLike = "auto",
10101011
compressor: CompressorLike = "auto",
10111012
serializer: SerializerLike = "auto",
1012-
fill_value: Any | None = None,
1013+
fill_value: Any | None = DEFAULT_FILL_VALUE,
10131014
order: MemoryOrder | None = None,
10141015
attributes: dict[str, JSON] | None = None,
10151016
chunk_key_encoding: ChunkKeyEncodingLike | None = None,
@@ -2430,7 +2431,7 @@ def create_array(
24302431
compressors: CompressorsLike = "auto",
24312432
compressor: CompressorLike = "auto",
24322433
serializer: SerializerLike = "auto",
2433-
fill_value: Any | None = None,
2434+
fill_value: Any | None = DEFAULT_FILL_VALUE,
24342435
order: MemoryOrder | None = None,
24352436
attributes: dict[str, JSON] | None = None,
24362437
chunk_key_encoding: ChunkKeyEncodingLike | None = None,
@@ -2835,7 +2836,7 @@ def array(
28352836
compressors: CompressorsLike = "auto",
28362837
compressor: CompressorLike = None,
28372838
serializer: SerializerLike = "auto",
2838-
fill_value: Any | None = 0,
2839+
fill_value: Any | None = DEFAULT_FILL_VALUE,
28392840
order: MemoryOrder | None = "C",
28402841
attributes: dict[str, JSON] | None = None,
28412842
chunk_key_encoding: ChunkKeyEncodingLike | None = None,

0 commit comments

Comments
 (0)