typing

Author: brokkoli71

src/zarr/core/metadata/v2.py

@@ -271,7 +271,9 @@ def parse_filters(data: object) -> tuple[numcodecs.abc.Codec, ...] | None:
             elif isinstance(val, dict):
                 out.append(numcodecs.get_codec(val))
             elif isinstance(val, str):
-                out.append(parse_filters(val)[0])
+                filter = parse_filters(val)
+                if filter is not None:
+                    out.extend(filter)
             else:
                 msg = f"For Zarr format 2 arrays, all elements of `filters` must be a numcodecs.abc.Codec or a dict or str representation of numcodecs.abc.Codec. Got {type(val)} at index {idx} instead."
                 raise TypeError(msg)

src/zarr/registry.py

@@ -232,7 +232,6 @@ def _parse_array_array_codec(data: dict[str, JSON] | str | Codec) -> ArrayArrayC
     """
     from zarr.abc.codec import ArrayArrayCodec
 
-    result: ArrayArrayCodec
     if isinstance(data, str):
         try:
             result = _resolve_codec({"name": data, "configuration": {}})

tests/test_array.py

@@ -10,6 +10,7 @@
 from unittest import mock
 
 import numcodecs
+import numcodecs.abc
 import numpy as np
 import numpy.typing as npt
 import pytest
@@ -1340,7 +1341,9 @@ async def test_invalid_chunk_encoding(store: MemoryStore) -> None:
             ("compressors", "bytes"),
         ],
     )
-    async def test_chunk_encoding_wrong_type(argument_key, codec, store: MemoryStore) -> None:
+    async def test_chunk_encoding_wrong_type(
+        argument_key: str, codec: str, store: MemoryStore
+    ) -> None:
         """
         Test that passing an invalid codec to create_array raises an error.
         """
@@ -1369,7 +1372,11 @@ async def test_chunk_encoding_wrong_type(argument_key, codec, store: MemoryStore
         ],
     )
     async def test_chunk_encoding_missing_arguments(
-        store: MemoryStore, argument_key, codec, codec_cls_name, zarr_format
+        store: MemoryStore,
+        argument_key: str,
+        codec: str,
+        codec_cls_name: str,
+        zarr_format: ZarrFormat,
     ) -> None:
         codec_key = codec if not isinstance(codec, tuple) else codec[0]
         argument_key_single = argument_key.removesuffix("s")