Apply ruff/flake8-simplify rule SIM118

SIM118 Use `key not in dict` instead of `key not in dict.keys()`

Author: DimitriPapadopoulos

src/zarr/core/group.py

@@ -54,7 +54,7 @@ def parse_zarr_format(data: Any) -> ZarrFormat:
 def parse_attributes(data: Any) -> dict[str, Any]:
     if data is None:
         return {}
-    elif isinstance(data, dict) and all(isinstance(v, str) for v in data.keys()):
+    elif isinstance(data, dict) and all(isinstance(k, str) for k in data):
         return data
     msg = f"Expected dict with string keys. Got {type(data)} instead."
     raise TypeError(msg)

src/zarr/registry.py

@@ -107,7 +107,7 @@ def fully_qualified_name(cls: type) -> str:
 
 
 def register_codec(key: str, codec_cls: type[Codec]) -> None:
-    if key not in __codec_registries.keys():
+    if key not in __codec_registries:
         __codec_registries[key] = Registry()
     __codec_registries[key].register(codec_cls)
 
@@ -158,7 +158,7 @@ def get_pipeline_class(reload_config: bool = False) -> type[CodecPipeline]:
     if pipeline_class:
         return pipeline_class
     raise BadConfigError(
-        f"Pipeline class '{path}' not found in registered pipelines: {list(__pipeline_registry.keys())}."
+        f"Pipeline class '{path}' not found in registered pipelines: {list(__pipeline_registry)}."
     )
 
 
@@ -172,7 +172,7 @@ def get_buffer_class(reload_config: bool = False) -> type[Buffer]:
     if buffer_class:
         return buffer_class
     raise BadConfigError(
-        f"Buffer class '{path}' not found in registered buffers: {list(__buffer_registry.keys())}."
+        f"Buffer class '{path}' not found in registered buffers: {list(__buffer_registry)}."
     )
 
 
@@ -185,7 +185,7 @@ def get_ndbuffer_class(reload_config: bool = False) -> type[NDBuffer]:
     if ndbuffer_class:
         return ndbuffer_class
     raise BadConfigError(
-        f"NDBuffer class '{path}' not found in registered buffers: {list(__ndbuffer_registry.keys())}."
+        f"NDBuffer class '{path}' not found in registered buffers: {list(__ndbuffer_registry)}."
     )
 
 

src/zarr/store/memory.py

@@ -137,7 +137,7 @@ async def list_dir(self, prefix: str) -> AsyncGenerator[str, None]:
             prefix = prefix[:-1]
 
         if prefix == "":
-            keys_unique = set(k.split("/")[0] for k in self._store_dict.keys())
+            keys_unique = set(k.split("/")[0] for k in self._store_dict)
         else:
             # Our dictionary doesn't contain directory markers, but we want to include
             # a pseudo directory when there's a nested item and we're listing an

tests/v3/test_store/test_stateful_store.py

@@ -131,7 +131,7 @@ def get(self, key: str, data: DataObject) -> None:
     @rule(key=paths, data=st.data())
     def get_invalid_keys(self, key: str, data: DataObject) -> None:
         note("(get_invalid)")
-        assume(key not in self.model.keys())
+        assume(key not in self.model)
         assert self.store.get(key, self.prototype) is None
 
     @precondition(lambda self: len(self.model.keys()) > 0)