Skip to content

Commit 64b9371

Browse files
committed
fixup
1 parent f81364b commit 64b9371

File tree

1 file changed

+6
-9
lines changed

1 file changed

+6
-9
lines changed

src/zarr/store/common.py

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -104,16 +104,13 @@ async def make_store_path(
104104
elif isinstance(store_like, Path):
105105
result = StorePath(await LocalStore.open(root=store_like, mode=mode or "r"))
106106
elif isinstance(store_like, str):
107-
try:
108-
fs, path = fsspec.url_to_fs(store_like, **storage_options)
109-
except Exception:
110-
# not sure what to do here, but I don't want this to fail...
111-
pass
107+
storage_options = storage_options or {}
108+
fs, path = fsspec.url_to_fs(store_like, **storage_options)
109+
if "file" not in fs.protocol:
110+
storage_options = storage_options or {}
111+
result = StorePath(RemoteStore(url=store_like, mode=mode or "r", **storage_options))
112112
else:
113-
if "file" not in fs.protocol:
114-
storage_options = storage_options or {}
115-
return StorePath(RemoteStore(url=store_like, mode=mode or "r", **storage_options))
116-
result = StorePath(await LocalStore.open(root=Path(store_like), mode=mode or "r"))
113+
result = StorePath(await LocalStore.open(root=Path(store_like), mode=mode or "r"))
117114
elif isinstance(store_like, dict):
118115
# We deliberate only consider dict[str, Buffer] here, and not arbitrary mutable mappings.
119116
# By only allowing dictionaries, which are in-memory, we know that MemoryStore appropriate.

0 commit comments

Comments
 (0)