Skip to content

Commit 70f1344

Browse files
committed
apply suggestions: mode defaults to r
1 parent ac1d7fd commit 70f1344

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/zarr/storage/_common.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -292,13 +292,15 @@ async def make_store_path(
292292
else:
293293
assert mode in (None, "r", "r+", "a", "w", "w-")
294294
# if mode 'r' was provided, we'll open any new stores as read-only
295+
if mode is None:
296+
mode = "r"
295297
_read_only = mode == "r"
296298
if isinstance(store_like, Store):
297299
store = store_like
298300
elif store_like is None:
299301
store = await MemoryStore.open(read_only=_read_only)
300302
elif isinstance(store_like, Path) and store_like.suffix == ".zip":
301-
store = await ZipStore.open(path=store_like, mode=mode or "r")
303+
store = await ZipStore.open(path=store_like, mode=mode)
302304
elif isinstance(store_like, Path):
303305
store = await LocalStore.open(root=store_like, read_only=_read_only)
304306
elif isinstance(store_like, str):
@@ -310,7 +312,7 @@ async def make_store_path(
310312
store_like, storage_options=storage_options, read_only=_read_only
311313
)
312314
elif store_like.endswith(".zip"):
313-
store = await ZipStore.open(path=Path(store_like), mode=mode or "r")
315+
store = await ZipStore.open(path=Path(store_like), mode=mode)
314316
else:
315317
store = await LocalStore.open(root=Path(store_like), read_only=_read_only)
316318
elif isinstance(store_like, dict):

0 commit comments

Comments
 (0)