Use explicit json encoder args

Author: will-moore

src/zarr/core/metadata/v3.py

@@ -134,9 +134,30 @@ def parse_storage_transformers(data: object) -> tuple[dict[str, JSON], ...]:
 
 
 class V3JsonEncoder(json.JSONEncoder):
-    def __init__(self, *args: Any, **kwargs: Any) -> None:
-        super().__init__(*args, **kwargs)
-        self.indent = kwargs.pop("indent") or config.get("json_indent")
+    def __init__(
+        self,
+        *,
+        skipkeys=False,
+        ensure_ascii=True,
+        check_circular=True,
+        allow_nan=True,
+        sort_keys=False,
+        indent=None,
+        separators=None,
+        default=None,
+    ) -> None:
+        if indent is None:
+            indent = config.get("json_indent")
+        super().__init__(
+            skipkeys=skipkeys,
+            ensure_ascii=ensure_ascii,
+            check_circular=check_circular,
+            allow_nan=allow_nan,
+            sort_keys=sort_keys,
+            indent=indent,
+            separators=separators,
+            default=default,
+        )
 
     def default(self, o: object) -> Any:
         if isinstance(o, np.dtype):

tests/test_metadata/test_v3.py

@@ -310,19 +310,7 @@ def test_json_indent(indent: int):
     with config.set({"json_indent": indent}):
         m = GroupMetadata()
         d = m.to_buffer_dict(default_buffer_prototype())["zarr.json"].to_bytes()
-
-        class TestIndentEncoder(json.JSONEncoder):
-            def __init__(self, *args: Any, **kwargs: Any) -> None:
-                super().__init__(*args, **kwargs)
-                self.indent = indent
-
-        # using json.JSONEncoder adds an extra ' ' on each line
-        # compared with json.dumps(json.loads(d), indent=2)...
-        expected = json.dumps(json.loads(d), cls=TestIndentEncoder).encode()
-        assert d == expected
-        # ...but we can check that None really removes indent.
-        if indent is None:
-            assert d == json.dumps(json.loads(d), indent=indent).encode()
+        assert d == json.dumps(json.loads(d), indent=indent).encode()
 
 
 # @pytest.mark.parametrize("fill_value", [-1, 0, 1, 2932897])