lint

Author: d-v-b

src/zarr/codecs/gzip.py

@@ -84,19 +84,19 @@ def _check_json_v2(cls, data: object) -> TypeGuard[GZipJSON_V2]:
         return (
             isinstance(data, Mapping)
             and set(data.keys()) == {"id", "level"}
-            and data["id"] == "gzip"  # type: ignore[typeddict-item]
-            and isinstance(data["level"], int)  # type: ignore[typeddict-item]
+            and data["id"] == "gzip"
+            and isinstance(data["level"], int)
         )
 
     @classmethod
     def _check_json_v3(cls, data: object) -> TypeGuard[GZipJSON_V3]:
         return (
             isinstance(data, Mapping)
             and set(data.keys()) == {"name", "configuration"}
-            and data["name"] == "gzip"  # type: ignore[typeddict-item]
-            and isinstance(data["configuration"], Mapping)  # type: ignore[typeddict-item]
-            and "level" in data["configuration"]  # type: ignore[typeddict-item]
-            and isinstance(data["configuration"]["level"], int)  # type: ignore[typeddict-item]
+            and data["name"] == "gzip"
+            and isinstance(data["configuration"], Mapping)
+            and "level" in data["configuration"]
+            and isinstance(data["configuration"]["level"], int)
         )
 
     @classmethod

src/zarr/codecs/numcodecs/_codecs.py

@@ -86,9 +86,9 @@ def __init__(self, **codec_config: Any) -> None:
             self,
             "_codec",
             get_numcodec(
-                {"id": self._codec_id, **{k: v for k, v in codec_config.items() if k != "id"}}
+                {"id": self._codec_id, **{k: v for k, v in codec_config.items() if k != "id"}}  # type: ignore[typeddict-item]
             ),
-        )  # type: ignore[typeddict-item]
+        )
         object.__setattr__(self, "codec_config", self._codec.get_config())
 
     def to_dict(self) -> dict[str, JSON]:

src/zarr/codecs/numcodecs/adler32.py

@@ -50,7 +50,7 @@ def check_json_v2(data: object) -> TypeGuard[Adler32JSON_V2]:
     return (
         _check_codecjson_v2(data)
         and data["id"] == "adler32"
-        and ("location" not in data or data["location"] in ("start", "end"))
+        and ("location" not in data or data["location"] in ("start", "end"))  # type: ignore[typeddict-item]
     )
 
 

src/zarr/codecs/numcodecs/bitround.py

@@ -46,8 +46,8 @@ def check_json_v2(data: object) -> TypeGuard[BitRoundJSON_V2]:
         _check_codecjson_v2(data)
         and data["id"] == "bitround"
         and "keepbits" in data
-        and isinstance(data["keepbits"], int)
-        and data["keepbits"] > 0
+        and isinstance(data["keepbits"], int)  # type: ignore[typeddict-item]
+        and data["keepbits"] > 0  # type: ignore[typeddict-item]
     )
 
 

src/zarr/codecs/numcodecs/bz2.py

@@ -46,8 +46,8 @@ def check_json_v2(data: object) -> TypeGuard[BZ2JSON_V2]:
         _check_codecjson_v2(data)
         and data["id"] == "bz2"
         and "level" in data
-        and isinstance(data["level"], int)
-        and 1 <= data["level"] <= 9
+        and isinstance(data["level"], int)  # type: ignore[typeddict-item]
+        and 1 <= data["level"] <= 9  # type: ignore[typeddict-item]
     )
 
 

src/zarr/codecs/numcodecs/crc32.py

@@ -47,7 +47,7 @@ def check_json_v2(data: object) -> TypeGuard[Crc32JSON_V2]:
     return (
         _check_codecjson_v2(data)
         and data["id"] == "crc32"
-        and ("location" not in data or data["location"] in ("start", "end"))
+        and ("location" not in data or data["location"] in ("start", "end"))  # type: ignore[typeddict-item]
     )
 
 

src/zarr/codecs/numcodecs/crc32c.py

@@ -33,7 +33,7 @@ def check_json_v2(data: object) -> TypeGuard[Crc32cJSON_V2]:
     return (
         _check_codecjson_v2(data)
         and data["id"] == "crc32c"
-        and ("location" not in data or data["location"] in ("start", "end"))
+        and ("location" not in data or data["location"] in ("start", "end"))  # type: ignore[typeddict-item]
     )
 
 
@@ -77,8 +77,6 @@ def _from_json_v2(cls, data: CodecJSON_V2) -> Self:
     @classmethod
     def _from_json_v3(cls, data: CodecJSON_V3) -> Self:
         if check_json_v3(data):
-            if isinstance(data, str):
-                return cls()
             config = data.get("configuration", {})
             return cls(**config)
         raise TypeError(f"Invalid JSON: {data}")

src/zarr/codecs/numcodecs/gzip.py

@@ -27,8 +27,8 @@ def check_json_v2(data: object) -> TypeGuard[GZipJSON_V2]:
         _check_codecjson_v2(data)
         and data["id"] == "gzip"
         and "level" in data
-        and isinstance(data["level"], int)
-        and 0 <= data["level"] <= 9
+        and isinstance(data["level"], int)  # type: ignore[typeddict-item]
+        and 0 <= data["level"] <= 9  # type: ignore[typeddict-item]
     )
 
 

src/zarr/codecs/numcodecs/jenkins_lookup3.py

@@ -52,8 +52,8 @@ def check_json_v2(data: object) -> TypeGuard[JenkinsLookup3JSON_V2]:
         and data["id"] == "jenkins_lookup3"
         and "initval" in data
         and "prefix" in data
-        and isinstance(data["initval"], int)
-        and isinstance(data["prefix"], bytes | None)
+        and isinstance(data["initval"], int)  # type: ignore[typeddict-item]
+        and isinstance(data["prefix"], bytes | None)  # type: ignore[typeddict-item]
     )
 
 

src/zarr/codecs/numcodecs/lz4.py

@@ -46,8 +46,8 @@ def check_json_v2(data: object) -> TypeGuard[LZ4JSON_V2]:
         _check_codecjson_v2(data)
         and data["id"] == "lz4"
         and "acceleration" in data
-        and isinstance(data["acceleration"], int)
-        and data["acceleration"] >= 1
+        and isinstance(data["acceleration"], int)  # type: ignore[typeddict-item]
+        and data["acceleration"] >= 1  # type: ignore[typeddict-item]
     )