Skip to content

Commit 876e67d

Browse files
committed
put v2_default_compressor under array
1 parent d11bf30 commit 876e67d

File tree

4 files changed

+21
-18
lines changed

4 files changed

+21
-18
lines changed

src/zarr/core/config.py

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,14 @@ def reset(self) -> None:
4242
defaults=[
4343
{
4444
"default_zarr_version": 3,
45-
"array": {"order": "C"},
45+
"array": {
46+
"order": "C",
47+
"v2_default_compressor": {
48+
"numeric": "zstd",
49+
"string": "vlen-utf8",
50+
"bytes": "vlen-bytes",
51+
},
52+
},
4653
"async": {"concurrency": 10, "timeout": None},
4754
"threading": {"max_workers": None},
4855
"json_indent": 2,
@@ -64,11 +71,7 @@ def reset(self) -> None:
6471
},
6572
"buffer": "zarr.core.buffer.cpu.Buffer",
6673
"ndbuffer": "zarr.core.buffer.cpu.NDBuffer",
67-
"v2_default_compressor": {
68-
"numeric": "zstd",
69-
"string": "vlen-utf8",
70-
"bytes": "vlen-bytes",
71-
},
74+
7275
}
7376
],
7477
)

src/zarr/core/metadata/v2.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,7 @@ def _default_filters_and_compressor(
337337
https://numpy.org/doc/2.1/reference/generated/numpy.dtype.kind.html
338338
"""
339339
dtype = np.dtype(dtype)
340-
default_compressor = config.get("v2_default_compressor")
340+
default_compressor = config.get("array.v2_default_compressor")
341341
if dtype.kind in "biufcmM":
342342
dtype_key = "numeric"
343343
elif dtype.kind in "U":

tests/test_config.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,14 @@ def test_config_defaults_set() -> None:
4141
assert config.defaults == [
4242
{
4343
"default_zarr_version": 3,
44-
"array": {"order": "C"},
44+
"array": {
45+
"order": "C",
46+
"v2_default_compressor": {
47+
"numeric": "zstd",
48+
"string": "vlen-utf8",
49+
"bytes": "vlen-bytes",
50+
},
51+
},
4552
"async": {"concurrency": 10, "timeout": None},
4653
"threading": {"max_workers": None},
4754
"json_indent": 2,
@@ -63,11 +70,6 @@ def test_config_defaults_set() -> None:
6370
"vlen-utf8": "zarr.codecs.vlen_utf8.VLenUTF8Codec",
6471
"vlen-bytes": "zarr.codecs.vlen_utf8.VLenBytesCodec",
6572
},
66-
"v2_default_compressor": {
67-
"numeric": "zstd",
68-
"string": "vlen-utf8",
69-
"bytes": "vlen-bytes",
70-
},
7173
}
7274
]
7375
assert config.get("array.order") == "C"

tests/test_v2.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,7 @@ def test_codec_pipeline() -> None:
8484
async def test_v2_encode_decode(dtype):
8585
with config.set(
8686
{
87-
"v2_default_compressor": {
88-
"bytes": "vlen-bytes",
89-
},
87+
"array.v2_default_compressor.bytes": "vlen-bytes",
9088
}
9189
):
9290
store = zarr.storage.MemoryStore()
@@ -126,7 +124,7 @@ def test_v2_encode_decode_with_data(dtype_value):
126124
dtype, value = dtype_value
127125
with config.set(
128126
{
129-
"v2_default_compressor": {
127+
"array.v2_default_compressor": {
130128
"string": "vlen-utf8",
131129
"bytes": "vlen-bytes",
132130
},
@@ -215,7 +213,7 @@ def test_v2_non_contiguous(array_order: Literal["C", "F"], data_order: Literal["
215213
def test_default_filters_and_compressor(dtype_expected: Any) -> None:
216214
with config.set(
217215
{
218-
"v2_default_compressor": {
216+
"array.v2_default_compressor": {
219217
"numeric": "zstd",
220218
"string": "vlen-utf8",
221219
"bytes": "vlen-bytes",

0 commit comments

Comments
 (0)