increase coverage, one way or another

Author: d-v-b

src/zarr/core/group.py

@@ -3326,7 +3326,9 @@ def _build_metadata_v3(zarr_json: dict[str, JSON]) -> ArrayV3Metadata | GroupMet
         case {"node_type": "group"}:
             return GroupMetadata.from_dict(zarr_json)
         case _:
-            raise ValueError("invalid value for `node_type` key in metadata document")
+            raise ValueError(
+                "invalid value for `node_type` key in metadata document"
+            )  # pragma: no cover
 
 
 def _build_metadata_v2(
@@ -3354,7 +3356,7 @@ def _build_node_v3(
         case GroupMetadata():
             return AsyncGroup(metadata, store_path=store_path)
         case _:
-            raise ValueError(f"Unexpected metadata type: {type(metadata)}")
+            raise ValueError(f"Unexpected metadata type: {type(metadata)}")  # pragma: no cover
 
 
 def _build_node_v2(
@@ -3370,7 +3372,7 @@ def _build_node_v2(
         case GroupMetadata():
             return AsyncGroup(metadata, store_path=store_path)
         case _:
-            raise ValueError(f"Unexpected metadata type: {type(metadata)}")
+            raise ValueError(f"Unexpected metadata type: {type(metadata)}")  # pragma: no cover
 
 
 async def _read_node_v2(store_path: StorePath) -> AsyncArray[ArrayV2Metadata] | AsyncGroup:
@@ -3401,7 +3403,7 @@ async def _read_node(
         case 3:
             return await _read_node_v3(store_path=store_path)
         case _:
-            raise ValueError(f"Unexpected zarr format: {zarr_format}")
+            raise ValueError(f"Unexpected zarr format: {zarr_format}")  # pragma: no cover
 
 
 async def _set_return_key(*, store: Store, key: str, value: Buffer, replace: bool) -> str:
@@ -3499,4 +3501,4 @@ def _create_rooted_hierarchy_sync(
     elif isinstance(async_node, AsyncArray):
         return Array(async_node)
     else:
-        raise TypeError(f"Unexpected node type: {type(async_node)}")
+        raise TypeError(f"Unexpected node type: {type(async_node)}")  # pragma: no cover

tests/test_group.py

@@ -25,6 +25,7 @@
     ConsolidatedMetadata,
     GroupMetadata,
     _create_rooted_hierarchy,
+    _create_rooted_hierarchy_sync,
     _join_paths,
     _normalize_path_keys,
     _normalize_paths,
@@ -1648,7 +1649,7 @@ async def test_create_rooted_hierarchy_group(store: Store, zarr_format, path: st
 
     nodes_create = root_meta | groups_expected_meta | arrays_expected_meta
 
-    g = await _create_rooted_hierarchy(spath, nodes=nodes_create, overwrite=True)
+    g = await _create_rooted_hierarchy(spath, nodes=nodes_create)
     assert g.metadata.attributes == {"path": root_key}
 
     members = await _collect_aiterator(g.members(max_depth=None))
@@ -1660,6 +1661,48 @@ async def test_create_rooted_hierarchy_group(store: Store, zarr_format, path: st
     assert members_observed_meta == members_expected_meta_relative
 
 
+# TODO: simplify testing sync versions of async functions.
+@pytest.mark.parametrize("store", ["memory", "local"], indirect=True)
+@pytest.mark.parametrize("zarr_format", [2, 3])
+@pytest.mark.parametrize("root_key", ["", "root"])
+@pytest.mark.parametrize("path", ["", "foo"])
+def test_create_rooted_hierarchy_sync_group(store: Store, zarr_format, path: str, root_key: str):
+    """
+    Test that the _create_rooted_hierarchy_sync can create a group.
+    """
+    spath = sync(make_store_path(store, path=path))
+    root_meta = {root_key: GroupMetadata(zarr_format=zarr_format, attributes={"path": root_key})}
+    group_names = ["a", "a/b"]
+    array_names = ["a/b/c", "a/b/d"]
+
+    # just to ensure that we don't use the same name twice in tests
+    assert set(group_names) & set(array_names) == set()
+
+    groups_expected_meta = {
+        _join_paths([root_key, node_name]): GroupMetadata(
+            zarr_format=zarr_format, attributes={"path": node_name}
+        )
+        for node_name in group_names
+    }
+    arrays_expected_meta = {
+        _join_paths([root_key, node_name]): meta_from_array(np.zeros(4), zarr_format=zarr_format)
+        for node_name in array_names
+    }
+
+    nodes_create = root_meta | groups_expected_meta | arrays_expected_meta
+
+    g = _create_rooted_hierarchy_sync(spath, nodes=nodes_create)
+    assert g.metadata.attributes == {"path": root_key}
+
+    members = g.members(max_depth=None)
+    members_observed_meta = {k: v.metadata for k, v in members}
+    members_expected_meta_relative = {
+        k.removeprefix(root_key).lstrip("/"): v
+        for k, v in (groups_expected_meta | arrays_expected_meta).items()
+    }
+    assert members_observed_meta == members_expected_meta_relative
+
+
 @pytest.mark.parametrize("store", ["memory", "local"], indirect=True)
 @pytest.mark.parametrize("zarr_format", [2, 3])
 @pytest.mark.parametrize("root_key", ["", "root"])