Apply new ruff rules (preview mode) (#2235)

* Apply ruff/Pyflakes rule F841

F841 Local variable is assigned to but never used

This issue is triggered in preview mode.

* Apply ruff/flake8-pyi PYI059

PYI059 `Generic[]` should always be the last base class

This future rule is triggered in preview mode.

* Apply ruff rule RUF021

RUF021 Parenthesize `a and b` expressions when chaining `and` and `or`
       together, to make the precedence clear

This future rule is triggered in preview mode.

* Apply ruff rule RUF022

RUF022 `__all__` is not sorted

This future rule is triggered in preview mode.

Author: DimitriPapadopoulos

src/zarr/__init__.py

@@ -34,14 +34,13 @@
 assert not __version__.startswith("0.0.0")
 
 __all__ = [
-    "__version__",
-    "config",
     "Array",
     "AsyncArray",
-    "Group",
     "AsyncGroup",
-    "tree",
+    "Group",
+    "__version__",
     "array",
+    "config",
     "consolidate_metadata",
     "copy",
     "copy_all",
@@ -63,6 +62,7 @@
     "save",
     "save_array",
     "save_group",
+    "tree",
     "zeros",
     "zeros_like",
 ]

src/zarr/abc/codec.py

@@ -20,21 +20,21 @@
     from zarr.core.indexing import SelectorTuple
 
 __all__ = [
-    "CodecInput",
-    "CodecOutput",
     "ArrayArrayCodec",
     "ArrayBytesCodec",
-    "BytesBytesCodec",
     "ArrayBytesCodecPartialDecodeMixin",
     "ArrayBytesCodecPartialEncodeMixin",
+    "BytesBytesCodec",
+    "CodecInput",
+    "CodecOutput",
     "CodecPipeline",
 ]
 
 CodecInput = TypeVar("CodecInput", bound=NDBuffer | Buffer)
 CodecOutput = TypeVar("CodecOutput", bound=NDBuffer | Buffer)
 
 
-class _Codec(Generic[CodecInput, CodecOutput], Metadata):
+class _Codec(Metadata, Generic[CodecInput, CodecOutput]):
     """Generic base class for codecs.
     Please use ArrayArrayCodec, ArrayBytesCodec or BytesBytesCodec for subclassing.
 

src/zarr/abc/store.py

@@ -14,7 +14,7 @@
     from zarr.core.buffer import Buffer, BufferPrototype
     from zarr.core.common import AccessModeLiteral, BytesLike
 
-__all__ = ["Store", "AccessMode", "ByteGetter", "ByteSetter", "set_or_delete"]
+__all__ = ["AccessMode", "ByteGetter", "ByteSetter", "Store", "set_or_delete"]
 
 ByteRangeRequest: TypeAlias = tuple[int | None, int | None]
 

src/zarr/api/asynchronous.py

@@ -30,29 +30,29 @@
     PathLike = str
 
 __all__ = [
+    "array",
     "consolidate_metadata",
     "copy",
     "copy_all",
     "copy_store",
-    "load",
-    "open",
-    "open_consolidated",
-    "save",
-    "save_array",
-    "save_group",
-    "tree",
-    "array",
-    "group",
-    "open_group",
     "create",
     "empty",
     "empty_like",
     "full",
     "full_like",
+    "group",
+    "load",
     "ones",
     "ones_like",
+    "open",
     "open_array",
+    "open_consolidated",
+    "open_group",
     "open_like",
+    "save",
+    "save_array",
+    "save_group",
+    "tree",
     "zeros",
     "zeros_like",
 ]

src/zarr/api/synchronous.py

@@ -14,29 +14,29 @@
     from zarr.store import StoreLike
 
 __all__ = [
+    "array",
     "consolidate_metadata",
     "copy",
     "copy_all",
     "copy_store",
-    "load",
-    "open",
-    "open_consolidated",
-    "save",
-    "save_array",
-    "save_group",
-    "tree",
-    "array",
-    "group",
-    "open_group",
     "create",
     "empty",
     "empty_like",
     "full",
     "full_like",
+    "group",
+    "load",
     "ones",
     "ones_like",
+    "open",
     "open_array",
+    "open_consolidated",
+    "open_group",
     "open_like",
+    "save",
+    "save_array",
+    "save_group",
+    "tree",
     "zeros",
     "zeros_like",
 ]

src/zarr/convenience.py

@@ -15,17 +15,17 @@
 )
 
 __all__ = [
+    "consolidate_metadata",
+    "copy",
+    "copy_all",
+    "copy_store",
+    "load",
     "open",
+    "open_consolidated",
     "save",
-    "load",
     "save_array",
     "save_group",
-    "copy",
-    "copy_all",
-    "copy_store",
     "tree",
-    "consolidate_metadata",
-    "open_consolidated",
 ]
 
 warnings.warn(

src/zarr/core/array.py

@@ -74,7 +74,7 @@
     from zarr.core.metadata.common import ArrayMetadata
 
 # Array and AsyncArray are defined in the base ``zarr`` namespace
-__all__ = ["parse_array_metadata", "create_codec_pipeline"]
+__all__ = ["create_codec_pipeline", "parse_array_metadata"]
 
 
 def parse_array_metadata(data: Any) -> ArrayV2Metadata | ArrayV3Metadata:

src/zarr/core/buffer/__init__.py

@@ -11,9 +11,9 @@
 __all__ = [
     "ArrayLike",
     "Buffer",
+    "BufferPrototype",
     "NDArrayLike",
     "NDBuffer",
-    "BufferPrototype",
     "default_buffer_prototype",
     "numpy_buffer_prototype",
 ]

src/zarr/core/buffer/core.py

@@ -467,7 +467,7 @@ def all_equal(self, other: Any, equal_nan: bool = True) -> bool:
             # Handle None fill_value for Zarr V2
             return False
         # use array_equal to obtain equal_nan=True functionality
-        data, other = np.broadcast_arrays(self._data, other)
+        _data, other = np.broadcast_arrays(self._data, other)
         return np.array_equal(
             self._data, other, equal_nan=equal_nan if self._data.dtype.kind not in "US" else False
         )

src/zarr/creation.py

@@ -16,18 +16,18 @@
 )
 
 __all__ = [
+    "array",
     "create",
     "empty",
-    "zeros",
-    "ones",
-    "full",
-    "array",
-    "open_array",
     "empty_like",
-    "zeros_like",
-    "ones_like",
+    "full",
     "full_like",
+    "ones",
+    "ones_like",
+    "open_array",
     "open_like",
+    "zeros",
+    "zeros_like",
 ]
 
 warnings.warn(