fixup: Make sure we don't copy arrays as we check for zeroes

Author: bojidar-bg

src/zarr/core/buffer/core.py

@@ -525,11 +525,12 @@ def all_equal(self, other: Any, equal_nan: bool = True) -> bool:
             return False
         # Handle positive and negative zero by comparing bit patterns:
         if (
-            np.array(other).dtype.kind == "f"
+            np.asarray(other).dtype.kind == "f"
             and other == 0.0
             and self._data.dtype.kind not in ("U", "S", "T", "O", "V")
         ):
-            return np.array_equiv(np.array(self._data).view("V"), np.array(other).view("V"))
+            _data, other = np.broadcast_arrays(self._data, other)
+            return np.array_equal(_data.view("V"), other.view("V"))
         # use array_equal to obtain equal_nan=True functionality
         # Since fill-value is a scalar, isn't there a faster path than allocating a new array for fill value
         # every single time we have to write data?

tests/test_array.py

@@ -906,21 +906,21 @@ def test_write_empty_chunks_behavior(
 
 @pytest.mark.parametrize("store", ["memory"], indirect=True)
 @pytest.mark.parametrize("fill_value", [0.0, -0.0])
+@pytest.mark.parametrize("dtype", ["f4", "f2"])
 def test_write_empty_chunks_negative_zero(
-    zarr_format: ZarrFormat, store: MemoryStore, fill_value: float
+    zarr_format: ZarrFormat, store: MemoryStore, fill_value: float, dtype: str
 ) -> None:
     # regression test for https://github.com/zarr-developers/zarr-python/issues/3144
 
     arr = zarr.create_array(
         store=store,
         shape=(2,),
         zarr_format=zarr_format,
-        dtype="f4",
+        dtype=dtype,
         fill_value=fill_value,
         chunks=(1,),
         config={"write_empty_chunks": False},
     )
-
     assert arr.nchunks_initialized == 0
 
     # initialize the with the negated fill value (-0.0 for +0.0, +0.0 for -0.0)