Merge branch 'feat/read-funcs' of github.com:d-v-b/zarr-python into feat/read-funcs

Author: d-v-b

src/zarr/core/array.py

@@ -3787,7 +3787,9 @@ def _parse_chunk_encoding_v2(
     if filters == "auto":
         _filters = default_filters
     else:
-        if not all(isinstance(f, numcodecs.abc.Codec) for f in filters):
+        if isinstance(filters, Iterable) and not all(
+            isinstance(f, numcodecs.abc.Codec) for f in filters
+        ):
             raise TypeError(
                 "For Zarr v2 arrays, all elements of `filters` must be numcodecs codecs."
             )

src/zarr/testing/strategies.py

@@ -10,6 +10,7 @@
 from zarr.core.array import Array
 from zarr.core.sync import sync
 from zarr.storage import MemoryStore, StoreLike
+from zarr.storage.common import _dereference_path
 
 # Copied from Xarray
 _attr_keys = st.text(st.characters(), min_size=1)
@@ -137,7 +138,7 @@ def arrays(
 
     expected_attrs = {} if attributes is None else attributes
 
-    array_path = path + ("/" if not path.endswith("/") else "") + name
+    array_path = _dereference_path(path, name)
     root = zarr.open_group(store, mode="w", zarr_format=zarr_format)
 
     a = root.create_array(

tests/test_group.py

@@ -614,20 +614,24 @@ def test_group_create_array(
     data = np.arange(np.prod(shape)).reshape(shape).astype(dtype)
 
     if method == "create_array":
-        array = group.create_array(name="array", shape=shape, dtype=dtype, data=data)
+        array = group.create_array(name="array", shape=shape, dtype=dtype)
+        array[:] = data
     elif method == "array":
         with pytest.warns(DeprecationWarning):
-            array = group.array(name="array", shape=shape, dtype=dtype, data=data)
+            array = group.array(name="array", shape=shape, dtype=dtype)
+            array[:] = data
     else:
         raise AssertionError
 
     if not overwrite:
         if method == "create_array":
             with pytest.raises(ContainsArrayError):
-                group.create_array(name="array", shape=shape, dtype=dtype, data=data)
+                a = group.create_array(name="array", shape=shape, dtype=dtype)
+                a[:] = data
         elif method == "array":
             with pytest.raises(ContainsArrayError), pytest.warns(DeprecationWarning):
-                group.array(name="array", shape=shape, dtype=dtype, data=data)
+                a = group.array(name="array", shape=shape, dtype=dtype)
+                a[:] = data
     assert array.shape == shape
     assert array.dtype == np.dtype(dtype)
     assert np.array_equal(array[:], data)