Skip to content

Commit 9342439

Browse files
committed
Open store for mode = r+
1 parent 2b2b387 commit 9342439

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

src/zarr/storage/_local.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,13 +132,19 @@ async def open(
132132
Store
133133
The opened store instance.
134134
"""
135+
# If mode = 'r+', want to open in read only mode (fail if exists),
136+
# but return a writeable store
135137
if mode is not None:
136138
read_only_creation = mode in ["r", "r+"]
137139
else:
138140
read_only_creation = read_only
139141
store = cls(root, read_only=read_only_creation)
140142
await store._open()
141-
return store.with_read_only(read_only)
143+
144+
# Set read_only state
145+
store = store.with_read_only(read_only)
146+
await store._open()
147+
return store
142148

143149
async def _open(self, *, mode: AccessModeLiteral | None = None) -> None:
144150
if not self.read_only:

0 commit comments

Comments
 (0)